Bug 1918524: Update Makefile to work with containers #789

michaelgugino · 2021-01-13T21:58:04Z

No description provided.

elmiko · 2021-01-13T22:34:42Z

i was able to run this, and it did complete through the unit tests. some of the tests pass, but some fail and seem to be missing /usr/local/kubebuilder/bin/etcd. the failures seem mixed between mao and vsphere tests for me.

seems like we might want to add separate make targets for the mao unit test and vsphere tests at some point too, just so that we can test with more granularity where needed.

michaelgugino · 2021-01-14T13:28:26Z

i was able to run this, and it did complete through the unit tests. some of the tests pass, but some fail and seem to be missing /usr/local/kubebuilder/bin/etcd. the failures seem mixed between mao and vsphere tests for me.

seems like we might want to add separate make targets for the mao unit test and vsphere tests at some point too, just so that we can test with more granularity where needed.

We actually have to run 'make test' as that downloads kubebuilder into the container. Make unit is only useful if using NO_DOCKER=1 and you have kubebuilder already installed.

This is somewhat confusing and we could probably change it, but this is the first step.

elmiko · 2021-01-14T15:00:13Z

ack, thanks for the clarification!

elmiko · 2021-01-14T16:48:28Z

just wanted to say that i tried make test and it worked for me, everything passed.

elmiko · 2021-01-14T18:44:57Z

Makefile

 else
-  DOCKER_CMD := docker run --env GO111MODULE=$(GO111MODULE) --env GOFLAGS=$(GOFLAGS) --rm -v "$(PWD)":/go/src/github.com/openshift/machine-api-operator:Z -w /go/src/github.com/openshift/machine-api-operator golang:1.13
+  DOCKER_CMD := docker run --env GO111MODULE=$(GO111MODULE) --env GOFLAGS=$(GOFLAGS) --rm -v "$(PWD)":/go/src/github.com/openshift/machine-api-operator:Z -w /go/src/github.com/openshift/machine-api-operator golang:1.15
+#  DOCKER_CMD := docker run --env GO111MODULE=$(GO111MODULE) --env GOFLAGS=$(GOFLAGS) --rm -v "$(PWD)":/go/src/github.com/openshift/machine-api-operator:Z -w /go/src/github.com/openshift/machine-api-operator registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.15-openshift-4.6


are you going to leave this in for reference to the rhel stuff?

Yes, for now. If you want to test with the same image we build with, comment/uncomment those lines. Possibly in the future make it more configurable, but it want people that don't have a CI registry pull secret to be able to build and test our bits.

elmiko

this worked for me, did you have some follow on changes you wanted to add @michaelgugino ?
/approve

openshift-ci-robot · 2021-01-14T18:45:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JoelSpeed · 2021-01-19T11:09:13Z

Seems to work on mac too
/lgtm

openshift-bot · 2021-01-19T14:20:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-19T14:46:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-19T17:23:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-19T20:38:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-19T22:47:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-20T00:57:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-20T01:24:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-20T03:20:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-20T04:25:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-20T05:30:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-20T08:19:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-20T10:16:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

JoelSpeed · 2021-01-20T10:24:28Z

/hold We don't need this to retest vSphere constantly. Please either add a BZ and hold cancel or wait til master opens and hold cancl

openshift-ci-robot · 2021-01-20T23:06:33Z

@michaelgugino: This pull request references Bugzilla bug 1918524, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1918524: Update Makefile to work with containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

michaelgugino · 2021-01-20T23:06:43Z

/hold cancel

openshift-bot · 2021-01-20T23:29:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-21T01:39:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-21T07:30:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-21T07:57:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-21T09:27:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-21T09:40:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-21T11:50:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-01-21T13:46:04Z

@michaelgugino: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere-operator	`3f6d9d3`	link	`/test e2e-vsphere-operator`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2021-01-21T14:05:59Z

@michaelgugino: All pull requests linked via external trackers have merged:

openshift/machine-api-operator#789

Bugzilla bug 1918524 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1918524: Update Makefile to work with containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Update Makefile to work with containers

3f6d9d3

openshift-ci-robot requested review from alexander-demicev and elmiko January 13, 2021 22:02

elmiko mentioned this pull request Jan 13, 2021

[WIP] Equinix Metal Support #753

Closed

elmiko reviewed Jan 14, 2021

View reviewed changes

elmiko approved these changes Jan 14, 2021

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021

michaelgugino closed this Jan 15, 2021

michaelgugino reopened this Jan 15, 2021

openshift-ci-robot assigned JoelSpeed Jan 19, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021

michaelgugino changed the title ~~Update Makefile to work with containers~~ Bug 1918524: Update Makefile to work with containers Jan 20, 2021

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 20, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 20, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021

openshift-merge-robot merged commit ba833e8 into openshift:master Jan 21, 2021

Bug 1918524: Update Makefile to work with containers #789

Bug 1918524: Update Makefile to work with containers #789

Uh oh!

Conversation

michaelgugino commented Jan 13, 2021

Uh oh!

elmiko commented Jan 13, 2021

Uh oh!

michaelgugino commented Jan 14, 2021

Uh oh!

elmiko commented Jan 14, 2021

Uh oh!

elmiko commented Jan 14, 2021

Uh oh!

elmiko Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

michaelgugino Jan 15, 2021

Choose a reason for hiding this comment

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 14, 2021

Uh oh!

JoelSpeed commented Jan 19, 2021

Uh oh!

openshift-bot commented Jan 19, 2021

Uh oh!

openshift-bot commented Jan 19, 2021

Uh oh!

openshift-bot commented Jan 19, 2021

Uh oh!

openshift-bot commented Jan 19, 2021

Uh oh!

openshift-bot commented Jan 19, 2021

Uh oh!

openshift-bot commented Jan 20, 2021

Uh oh!

openshift-bot commented Jan 20, 2021

Uh oh!

openshift-bot commented Jan 20, 2021

Uh oh!

openshift-bot commented Jan 20, 2021

Uh oh!

openshift-bot commented Jan 20, 2021

Uh oh!

openshift-bot commented Jan 20, 2021

Uh oh!

openshift-bot commented Jan 20, 2021

Uh oh!

JoelSpeed commented Jan 20, 2021

Uh oh!

openshift-ci-robot commented Jan 20, 2021

Uh oh!

michaelgugino commented Jan 20, 2021

Uh oh!

openshift-bot commented Jan 20, 2021

Uh oh!

openshift-bot commented Jan 21, 2021

Uh oh!

openshift-bot commented Jan 21, 2021

Uh oh!

openshift-bot commented Jan 21, 2021

Uh oh!

openshift-bot commented Jan 21, 2021

Uh oh!

openshift-bot commented Jan 21, 2021

Uh oh!

openshift-bot commented Jan 21, 2021

Uh oh!

openshift-ci bot commented Jan 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

openshift-ci bot commented Jan 21, 2021 •

edited

Loading