[WIP] Equinix Metal Support #753

detiber · 2020-11-13T19:41:42Z

Depends on:
openshift/cloud-credential-operator#283
openshift/api#784

openshift-ci-robot · 2020-11-13T19:42:00Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign elmiko after the PR has been reviewed.
You can assign the PR to them by writing /assign @elmiko in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-11-13T19:42:06Z

Hi @detiber. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

detiber · 2020-11-13T19:42:48Z

go.mod


 replace sigs.k8s.io/cluster-api-provider-azure => github.com/openshift/cluster-api-provider-azure v0.1.0-alpha.3.0.20201016155852-4090a6970205
+
+replace github.com/openshift/api => github.com/detiber/api v0.0.0-20201113192824-c19de3594400


Relies on changes in openshift/api#784

elmiko

this looks reasonable to me. i have not had a chance to run it yet, although the binary build and unit tests worked. i had a minor suggestion about the CCO repo, but it's not a blocker.

i think we should put a hold here just to make sure we don't do anything before the api changes merge.
/lgtm
/hold until openshift/api#784 has merged

install/0000_30_machine-api-operator_00_credentials-request.yaml

elmiko · 2021-01-12T21:07:17Z

one more comment, this should be rebased as some of the baremetal stuff has been removed since it was first posted.

openshift-ci · 2021-01-12T21:09:46Z

@detiber: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/yaml-lint	`4e41837`	link	`/test yaml-lint`
ci/prow/unit	`4e41837`	link	`/test unit`
ci/prow/e2e-aws-operator	`4e41837`	link	`/test e2e-aws-operator`
ci/prow/e2e-gcp-operator	`4e41837`	link	`/test e2e-gcp-operator`
ci/prow/e2e-aws	`4e41837`	link	`/test e2e-aws`
ci/prow/e2e-azure	`4e41837`	link	`/test e2e-azure`
ci/prow/e2e-gcp	`4e41837`	link	`/test e2e-gcp`
ci/prow/generate	`4e41837`	link	`/test generate`
ci/prow/e2e-vsphere	`4e41837`	link	`/test e2e-vsphere`
ci/prow/goimports	`4e41837`	link	`/test goimports`
ci/prow/e2e-vsphere-operator	`4e41837`	link	`/test e2e-vsphere-operator`
ci/prow/e2e-azure-operator	`4e41837`	link	`/test e2e-azure-operator`
ci/prow/e2e-metal-ipi	`4e41837`	link	`/test e2e-metal-ipi`
ci/prow/images	`4e41837`	link	`/test images`
ci/prow/govet	`4e41837`	link	`/test govet`
ci/prow/e2e-aws-workers-rhel7	`4e41837`	link	`/test e2e-aws-workers-rhel7`
ci/prow/golint	`4e41837`	link	`/test golint`
ci/prow/e2e-libvirt	`4e41837`	link	`/test e2e-libvirt`
ci/prow/e2e-aws-upgrade	`4e41837`	link	`/test e2e-aws-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2021-01-13T19:29:03Z

New changes are detected. LGTM label has been removed.

detiber · 2021-01-13T19:31:26Z

go.mod


 replace sigs.k8s.io/cluster-api-provider-azure => github.com/openshift/cluster-api-provider-azure v0.1.0-alpha.3.0.20201130182513-88b90230f2a4
+
+replace github.com/openshift/api => github.com/detiber/api v0.0.0-20210113181726-19e9a251beff


Temporary workaround until openshift/api#784 is merged

+1, that makes sense for now

detiber · 2021-01-13T19:37:14Z

Rebased, I'm having difficulty running the tests locally, they don't like running outside of docker (running hack/ci-test.sh directly due to not having the kubebuilder binaries installed where it wants them) and running in docker doesn't seem happy.

Not sure how to reconcile at the moment, but may try digging in further a little be latter on down the line.

elmiko · 2021-01-13T19:44:46Z

Rebased, I'm having difficulty running the tests locally, they don't like running outside of docker (running hack/ci-test.sh directly due to not having the kubebuilder binaries installed where it wants them) and running in docker doesn't seem happy.

yeah, i apologize for this but it's a known deficiency currently. i will spend some time to see if i can provide a good recipe for running these.

Not sure how to reconcile at the moment, but may try digging in further a little be latter on down the line.

i am going to take another look as well to see if we can't make this easier for you. this is a known issue

elmiko · 2021-01-13T22:25:39Z

@detiber i just saw that this pr got posted #789 , i haven't tested it too much yet but just wanted to share.

detiber · 2021-01-14T18:28:19Z

Updated, did some squashing, added the commit from #789 to enable local testing

elmiko · 2021-01-14T19:33:31Z

those changes worked for me, i was able to build the binary with make build and run the unit tests with make test. bonus, all the tests passed.

elmiko · 2021-02-19T19:25:35Z

just wanted to leave an update here, i am still working towards live testing of the equinix metal provider. i have access to the equinix platform and have been working through the upi installation process for openshift. my next step will be to add in the equinix specific provider bits and run some manual testing followed by attempting to run our e2e tests.

openshift-bot · 2021-05-27T07:37:47Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-ci · 2021-05-27T07:37:53Z

@detiber: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-06-26T11:18:14Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2021-07-26T14:05:29Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2021-07-26T14:05:38Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

displague · 2021-08-24T04:17:37Z

/reopen

displague · 2021-08-24T04:17:42Z

/remove-lifecycle rotten

openshift-ci · 2021-08-24T04:17:56Z

@displague: You can't reopen an issue/PR unless you authored it or you are a collaborator.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020

openshift-ci-robot requested review from Danil-Grigorev and alexander-demicev November 13, 2020 19:42

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2020

detiber commented Nov 13, 2020

View reviewed changes

displague mentioned this pull request Nov 13, 2020

[WIP] Add the Packet provider openshift/installer#3914

Closed

6 tasks

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2020

detiber force-pushed the metal branch from 75933fe to 4e41837 Compare November 24, 2020 21:43

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2020

displague mentioned this pull request Dec 10, 2020

Add the Equinix Metal provider openshift/installer#4472

Closed

6 tasks

elmiko reviewed Jan 12, 2021

View reviewed changes

install/0000_30_machine-api-operator_00_credentials-request.yaml Show resolved Hide resolved

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2021

openshift-ci-robot assigned elmiko Jan 12, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021

detiber mentioned this pull request Jan 13, 2021

Add support for Equinix Metal openshift/cloud-credential-operator#283

Closed

detiber force-pushed the metal branch from 4e41837 to 284f917 Compare January 13, 2021 19:29

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2021

detiber commented Jan 13, 2021

View reviewed changes

detiber force-pushed the metal branch from 284f917 to 3d9179d Compare January 14, 2021 18:26

detiber force-pushed the metal branch from 3d9179d to ac3c04b Compare January 21, 2021 20:13

WIP adding Packet support

6dffa38

detiber force-pushed the metal branch from ac3c04b to 6dffa38 Compare February 25, 2021 21:48

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2021

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 26, 2021

openshift-ci bot closed this Jul 26, 2021

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 24, 2021


		replace sigs.k8s.io/cluster-api-provider-azure => github.com/openshift/cluster-api-provider-azure v0.1.0-alpha.3.0.20201016155852-4090a6970205

		replace github.com/openshift/api => github.com/detiber/api v0.0.0-20201113192824-c19de3594400

[WIP] Equinix Metal Support #753

[WIP] Equinix Metal Support #753

Uh oh!

Conversation

detiber commented Nov 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 13, 2020

Uh oh!

openshift-ci-robot commented Nov 13, 2020

Uh oh!

detiber Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elmiko commented Jan 12, 2021

Uh oh!

openshift-ci bot commented Jan 12, 2021

Uh oh!

openshift-ci-robot commented Jan 13, 2021

Uh oh!

detiber Jan 13, 2021

Choose a reason for hiding this comment

Uh oh!

elmiko Jan 13, 2021

Choose a reason for hiding this comment

Uh oh!

detiber commented Jan 13, 2021

Uh oh!

elmiko commented Jan 13, 2021

Uh oh!

elmiko commented Jan 13, 2021

Uh oh!

detiber commented Jan 14, 2021

Uh oh!

elmiko commented Jan 14, 2021

Uh oh!

elmiko commented Feb 19, 2021

Uh oh!

openshift-bot commented May 27, 2021

Uh oh!

openshift-ci bot commented May 27, 2021

Uh oh!

openshift-bot commented Jun 26, 2021

Uh oh!

openshift-bot commented Jul 26, 2021

Uh oh!

openshift-ci bot commented Jul 26, 2021

Uh oh!

displague commented Aug 24, 2021

Uh oh!

displague commented Aug 24, 2021

Uh oh!

openshift-ci bot commented Aug 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

detiber commented Nov 13, 2020 •

edited

Loading