Skip to content

Rename ClusterName to ClusterID #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spangenberg wants to merge 1 commit into from
Closed

Rename ClusterName to ClusterID #103

spangenberg wants to merge 1 commit into from

Conversation

@spangenberg
Copy link
Contributor

@spangenberg spangenberg commented Oct 23, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: spangenberg

If they are not already assigned, you can assign the PR to them by writing /assign @spangenberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spangenberg
Copy link
Contributor Author

spangenberg commented Oct 23, 2018

/test e2e-aws

1 similar comment
@spangenberg
Copy link
Contributor Author

spangenberg commented Oct 23, 2018

/test e2e-aws

@enxebre
Copy link
Member

enxebre commented Oct 23, 2018 •
edited
Loading

hey @spangenberg this is all deprecated and going away. machineSets are now instantiated by the installer #101
https://github.com/openshift/installer/tree/master/pkg/asset/machines

@spangenberg spangenberg force-pushed the rename-cluster-name-to-cluster-id branch from 318c148 to 46394f5 Compare October 24, 2018 13:25
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 24, 2018
@enxebre
Copy link
Member

enxebre commented Oct 24, 2018 •
edited
Loading

hey @spangenberg this is all deprecated and going away. machineSets are now instantiated by the installer #101
https://github.com/openshift/installer/tree/master/pkg/asset/machines
So the config referencing machineSets/cluster is not used at all and will be dropped as soon as this get merged openshift/installer#518 so we don't break unmarshaling
can you please close this PR and if relevant open a new one against the installer machineset specs?

@enxebre enxebre closed this Nov 5, 2018
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
@openshift-merge-robot
Merge pull request openshift#103 from csrwng/handle-network-lb
e698609 
Add support for AWS Network Load Balancers
germanparente pushed a commit to germanparente/machine-api-operator that referenced this pull request Sep 23, 2025
@openshift-merge-robot
Merge pull request openshift#103 from JoelSpeed/termination-scheme
c71ec2f 
BUG 1856597: Pass scheme to client creation so that it uses scheme with Machine API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trawler trawler Awaiting requested review from trawler

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

Assignees

No one assigned

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spangenberg @openshift-ci-robot @enxebre