Skip to content

Remove machineset and cluster objects #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Oct 24, 2018
Merged

Remove machineset and cluster objects #101

openshift-merge-robot merged 3 commits into from
Oct 24, 2018

Conversation

@enxebre
Copy link
Member

@enxebre enxebre commented Oct 23, 2018 •
edited
Loading

Remove machineSet and cluster definitions as this is being created by the installer https://github.com/openshift/installer/tree/master/pkg/asset/machines
Prepare config to be dropped openshift/installer#518
blocked by #100

@enxebre enxebre added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Oct 23, 2018
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. labels Oct 23, 2018
@enxebre enxebre added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2018
@ingvagabund
Copy link
Member

ingvagabund commented Oct 23, 2018

Looks good in overall. So from now on the installer is responsible for deploying the cluster object, right?

@ingvagabund ingvagabund added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spangenberg
Copy link
Contributor

spangenberg commented Oct 23, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2018
@enxebre enxebre removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2018
@enxebre enxebre changed the title Remove ms Remove machineset and cluster objects Oct 23, 2018
This was referenced Oct 23, 2018
Merged
Closed
@enxebre
Copy link
Member Author

enxebre commented Oct 23, 2018

/test e2e-aws

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 23, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 23, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 24, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fd468f6 into openshift:master Oct 24, 2018
germanparente pushed a commit to germanparente/machine-api-operator that referenced this pull request Sep 23, 2025
@openshift-merge-robot
Merge pull request openshift#101 from abhinavdahiya/fix_image
245b581 
support sourceImage outside the existing project
germanparente pushed a commit to germanparente/machine-api-operator that referenced this pull request Sep 23, 2025
@openshift-merge-bot
Merge pull request openshift#101 from RadekManak/fix-exists
e586117 
OCPBUGS-43531: Refactor exists() to handle gcp API change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bison bison Awaiting requested review from bison

@spangenberg spangenberg Awaiting requested review from spangenberg

Assignees

@spangenberg spangenberg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@enxebre @ingvagabund @openshift-ci-robot @spangenberg @openshift-merge-robot