improve DefaultClientDialContext#944
Conversation
|
I performed the manual tests described #926 (comment) and #926 (comment) and haven't found any issues. I got the same results. |
|
/assign @sttts |
|
/cherry-pick release-4.6 |
|
@p0lyn0mial: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
openshift-ci-robot
added
the
approved
pkg/network/dialer_linux.go
Outdated
| Control: func(network, address string, con syscall.RawConn) error { | ||
| var err error | ||
| err = con.Control(func(fd uintptr) { | ||
| err = setDefaultSocketOptions(int(fd)) |
There was a problem hiding this comment.
/hold
good catch, thx
openshift-ci-robot
added
the
do-not-merge/hold
p0lyn0mial
force-pushed
the
improve-setting-tcp-usr-timeout
branch
2 times, most recently
from
e5bbe18 to
eb0dcb8
Compare
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
p0lyn0mial
force-pushed
the
improve-setting-tcp-usr-timeout
branch
from
eb0dcb8 to
c6a33e2
Compare
p0lyn0mial
force-pushed
the
improve-setting-tcp-usr-timeout
branch
from
c6a33e2 to
0fc42f4
Compare
wrapping the DialContext method and setting the socket options on a copy of the file descriptor is not deterministic. as per documentation attempting to change properties of the original using this duplicate may or may not have the desired effect. instead we should set the options on the original file descriptor.
p0lyn0mial
force-pushed
the
improve-setting-tcp-usr-timeout
branch
from
0fc42f4 to
a8786c0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@p0lyn0mial: new pull request created: #945 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
wrapping the DialContext method and setting the socket options on a copy of the file descriptor is not deterministic.
as per documentation attempting to change properties of the original using this duplicate
may or may not have the desired effect.
instead we should set the options on the original file descriptor.