Add MapToEnvVars helper function #548
Conversation
openshift-ci-robot
added
the
size/S
|
|
||
| func MapToEnvVars(proxyConfig map[string]string) []corev1.EnvVar { | ||
| if proxyConfig == nil { | ||
| return nil |
There was a problem hiding this comment.
i would return empty list maybe so we can append?
pkg/operator/v1helpers/helpers.go
Outdated
| return []error(agg) | ||
| } | ||
|
|
||
| func MapToEnvVars(proxyConfig map[string]string) []corev1.EnvVar { |
There was a problem hiding this comment.
nit: would make this env var name something generic
pkg/operator/v1helpers/helpers.go
Outdated
| return []error(agg) | ||
| } | ||
|
|
||
| func MapToEnvVars(proxyConfig map[string]string) []corev1.EnvVar { |
|
@mfojtik updated, ptal |
|
/lgtm |
pkg/operator/v1helpers/helpers.go
Outdated
| // MapToEnvVars converts a string-string map to a slice of corev1.EnvVar-s | ||
| func MapToEnvVars(mapEnvVars map[string]string) []corev1.EnvVar { | ||
| if mapEnvVars == nil { | ||
| return []corev1.EnvVar{} |
There was a problem hiding this comment.
@mfojtik convinced me it'll be easier to use this in append
There was a problem hiding this comment.
it is not. This has smell. Don't do magic.
pkg/operator/v1helpers/helpers.go
Outdated
| return []corev1.EnvVar{} | ||
| } | ||
|
|
||
| envVars := []corev1.EnvVar{} |
|
/lgtm |
mfojtik
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Add MapToEnvVars helper function
6 participants
/assign @mfojtik
since you asked for it in openshift/cluster-kube-controller-manager-operator#285 (comment) and on top of that we use it in 3 operators: kcm-o, kas-o and oas-o.
/assign @deads2k