add non-MITM proxy support #285
Conversation
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.2 |
|
@soltysh: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
| } | ||
|
|
||
| func proxyMapToEnvVars(proxyConfig map[string]string) []corev1.EnvVar { |
There was a problem hiding this comment.
TODO: move this to library-go :-)
| } | ||
|
|
||
| proxyEnvVars := proxyMapToEnvVars(proxyConfig) | ||
| for i, container := range required.Spec.Containers { |
There was a problem hiding this comment.
We can add it to 4.3
|
/retest |
|
@soltysh: new pull request created: #286 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
This builds on top of #284 but fixes wrong yaml import which was causing the error pointed out by Standa and modifies the configmap merging.
/assign @deads2k @stlaz