Skip to content

Bug 1714158: Prevent cert-syncer to act on stale data #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 2, 2019
Merged

Bug 1714158: Prevent cert-syncer to act on stale data #512

openshift-merge-robot merged 1 commit into from
Sep 2, 2019

Conversation

@tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Aug 26, 2019

4.1 backport of #424

/cc @sttts

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 26, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2019

@tnozicka: This pull request references Bugzilla bug 1714158, which is invalid:

  • expected dependent Bugzilla bug 1745571 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1714158: Prevent cert-syncer to act on stale data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2019
This was referenced Aug 26, 2019
Closed
Merged
@tnozicka
Copy link
Contributor Author

tnozicka commented Aug 26, 2019

fake bump in openshift/cluster-kube-apiserver-operator#557

@tnozicka
Copy link
Contributor Author

tnozicka commented Aug 26, 2019

/retest

sttts
sttts reviewed Aug 27, 2019
View reviewed changes
pkg/operator/staticpod/certsyncpod/certsync_controller.go
// Check with the live call it is really missing
configMap, err = c.configmapGetter.Get(cm.Name, metav1.GetOptions{})
if err == nil {
klog.Infof("Caches are stale. They don't see configmap '%s/%s', yet it is present", configMap.Namespace, configMap.Name)
Copy link
Contributor

@sttts sttts Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this something completely normal? Would at least use V(2).

Copy link
Contributor Author

@tnozicka tnozicka Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly, I don't want to touch it for backport

@sttts
Copy link
Contributor

sttts commented Aug 27, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@tnozicka
Copy link
Contributor Author

tnozicka commented Aug 27, 2019

/retest

@tnozicka
Copy link
Contributor Author

tnozicka commented Aug 29, 2019

/test all

@tnozicka
Copy link
Contributor Author

tnozicka commented Sep 2, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2019

@tnozicka: This pull request references Bugzilla bug 1714158, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka
Copy link
Contributor Author

tnozicka commented Sep 2, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 2, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2019

@tnozicka: This pull request references Bugzilla bug 1714158, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 2, 2019
@mfojtik
Copy link
Contributor

mfojtik commented Sep 2, 2019

This met all formal criteria for a backport approval.

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 2, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7e7e745 into openshift:release-4.1 Sep 2, 2019
@tnozicka tnozicka deleted the 4.1-1714158 branch September 2, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sttts sttts sttts left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tnozicka @openshift-ci-robot @sttts @mfojtik @openshift-merge-robot