Bug 1714158: Prevent cert-syncer to act on stale data #557

tnozicka · 2019-08-26T16:33:34Z

Requires:

Bug 1714158: Prevent cert-syncer to act on stale data library-go#512

picking up a backport of d0f4b03 from #520 to fix breaking api change in openshift/api#375 we got with the bump

openshift-ci-robot · 2019-08-26T16:33:38Z

@tnozicka: This pull request references Bugzilla bug 1714158, which is invalid:

expected dependent Bugzilla bug 1745571 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] Bug 1714158: Prevent cert-syncer to act on stale data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tnozicka · 2019-08-27T09:13:10Z

/retest

tnozicka · 2019-08-27T12:27:49Z

/retest

tnozicka · 2019-08-30T06:57:07Z

/retest

openshift-ci-robot · 2019-08-30T10:58:05Z

@tnozicka: This pull request references Bugzilla bug 1714158, which is invalid:

expected dependent Bugzilla bug 1745571 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] Bug 1714158: Prevent cert-syncer to act on stale data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tnozicka · 2019-09-02T12:11:18Z

/bugzilla refresh

openshift-ci-robot · 2019-09-02T12:11:21Z

@tnozicka: This pull request references Bugzilla bug 1714158, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tnozicka · 2019-09-02T12:12:19Z

/bugzilla refresh

openshift-ci-robot · 2019-09-02T12:12:23Z

@tnozicka: This pull request references Bugzilla bug 1714158, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tnozicka · 2019-09-02T13:51:46Z

...or/github.com/openshift/library-go/pkg/operator/staticpod/certsyncpod/certsync_controller.go

 			continue
+
 		case apierrors.IsNotFound(err) && cm.Optional:
+			// Check with the live call it is really missing


openshift-ci-robot · 2019-09-02T13:51:58Z

@tnozicka: This pull request references Bugzilla bug 1714158, which is valid.

Details

In response to this:

Bug 1714158: Prevent cert-syncer to act on stale data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts · 2019-09-02T14:20:56Z

pkg/operator/configobservation/apiserver/observe_apiserver.go

-// serving secure traffic.
-// We are disabling this because it doesn't work today and customers aren't going to be able to get the kube service network options right.
-// Customers may only use SNI.  I'm leaving this code in case we ever come up with a way to make an SNI-like thing based on IPs.
-var ObserveDefaultUserServingCertificate configobserver.ObserveConfigFunc = (&apiServerObserver{


why is this commit good? removal without explanation in the commit msg is not good.

this is bump of openshift/api not something this PR introduced

but it changes pkg/operator/configobservation/apiserver/observe_apiserver.go, not vendor/openshift/api.

this was a backport of breaking api change which just disabled the code, but left it there. this PR won the first bump and dealing with incompatibilities

tnozicka · 2019-09-02T14:37:35Z

/retest

sttts · 2019-09-02T15:02:20Z

/lgtm

openshift-ci-robot · 2019-09-02T15:02:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sttts,tnozicka]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2019-09-02T15:41:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-02T16:46:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mfojtik · 2019-09-03T08:26:40Z

The 4.2 is in the right state with right priority and the fix in master soaked, approving.

openshift-ci-robot · 2019-09-03T08:27:12Z

@tnozicka: All pull requests linked via external trackers have merged. Bugzilla bug 1714158 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1714158: Prevent cert-syncer to act on stale data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested a review from sttts August 26, 2019 16:33

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 26, 2019

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2019

tnozicka mentioned this pull request Aug 26, 2019

Bug 1714158: Prevent cert-syncer to act on stale data openshift/library-go#512

Merged

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 2, 2019

tnozicka and others added 2 commits September 2, 2019 15:47

bump(*) for openshift/library-go

91f4893

react to bump

17ea1fb

tnozicka force-pushed the 4.1-1714158 branch from c525475 to 17ea1fb Compare September 2, 2019 13:47

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2019

tnozicka changed the title ~~[WIP] Bug 1714158: Prevent cert-syncer to act on stale data~~ Bug 1714158: Prevent cert-syncer to act on stale data Sep 2, 2019

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2019

tnozicka commented Sep 2, 2019

View reviewed changes

sttts reviewed Sep 2, 2019

View reviewed changes

openshift-ci-robot assigned sttts Sep 2, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2019

mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 3, 2019

openshift-merge-robot merged commit d33d947 into openshift:release-4.1 Sep 3, 2019

tnozicka deleted the 4.1-1714158 branch September 3, 2019 08:27

Bug 1714158: Prevent cert-syncer to act on stale data #557

Bug 1714158: Prevent cert-syncer to act on stale data #557

Uh oh!

Conversation

tnozicka commented Aug 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 26, 2019

Uh oh!

tnozicka commented Aug 27, 2019

Uh oh!

tnozicka commented Aug 27, 2019

Uh oh!

tnozicka commented Aug 30, 2019

Uh oh!

openshift-ci-robot commented Aug 30, 2019

Uh oh!

tnozicka commented Sep 2, 2019

Uh oh!

openshift-ci-robot commented Sep 2, 2019

Uh oh!

tnozicka commented Sep 2, 2019

Uh oh!

openshift-ci-robot commented Sep 2, 2019

Uh oh!

tnozicka Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 2, 2019

Uh oh!

sttts Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

tnozicka Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

sttts Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

tnozicka Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

tnozicka commented Sep 2, 2019

Uh oh!

sttts commented Sep 2, 2019

Uh oh!

openshift-ci-robot commented Sep 2, 2019

Uh oh!

openshift-bot commented Sep 2, 2019

Uh oh!

openshift-bot commented Sep 2, 2019

Uh oh!

mfojtik commented Sep 3, 2019

Uh oh!

openshift-ci-robot commented Sep 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tnozicka commented Aug 26, 2019 •

edited

Loading