Skip to content

CNTRLPLANE-2247: test/library/encryption/kms/k8s_mock_kms_plugin_deployer: cleanup the signature of the DeployUpstreamMockKMSPlugin fn #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Feb 4, 2026
Merged

CNTRLPLANE-2247: test/library/encryption/kms/k8s_mock_kms_plugin_deployer: cleanup the signature of the DeployUpstreamMockKMSPlugin fn #2113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions test/library/encryption/kms/k8s_mock_kms_plugin_deployer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ type yamlTemplateData struct {
}

// DeployUpstreamMockKMSPlugin deploys the upstream mock KMS v2 plugin using embedded YAML assets.
// It returns a cleanup function that removes the entire namespace where the DaemonSet was deployed.
func DeployUpstreamMockKMSPlugin(ctx context.Context, t testing.TB, kubeClient kubernetes.Interface, namespace, image string) func() {
func DeployUpstreamMockKMSPlugin(ctx context.Context, t testing.TB, kubeClient kubernetes.Interface, namespace, image string) {
t.Helper()

t.Logf("Deploying upstream mock KMS v2 plugin in namespace %q using image %s", namespace, image)
Expand All @@ -64,8 +63,6 @@ func DeployUpstreamMockKMSPlugin(ctx context.Context, t testing.TB, kubeClient k
t.Fatalf("DaemonSet not ready: %v", err)
}
t.Logf("Upstream mock KMS v2 plugin deployed successfully!")

return nil
}

// applyUpstreamMockKMSPluginManifests applies all the KMS plugin manifests.
Expand Down