CNTRLPLANE-2247: test/library/encryption/kms/k8s_mock_kms_plugin_deployer: cleanup the signature of the DeployUpstreamMockKMSPlugin fn#2113
Conversation
|
@p0lyn0mial: This pull request references CNTRLPLANE-2247 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I intentionally didn't change the signature in case we'll need a cleanup function in the future. But we define it when it is needed |
… signature of the DeployUpstreamMockKMSPlugin fn
62d2290 to
cb5b3e4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@p0lyn0mial: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
we changed the function in #2112 but we forgot to update the signature.