Skip to content

CNTRLPLANE-2247: test/library/encryption/kms/k8s_mock_kms_plugin_deployer: cleanup the signature of the DeployUpstreamMockKMSPlugin fn#2113

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
p0lyn0mial:kms-upstream-plugin-cleanup
Feb 4, 2026
Merged

Conversation

@p0lyn0mial
Copy link
Copy Markdown
Contributor

we changed the function in #2112 but we forgot to update the signature.

@p0lyn0mial p0lyn0mial requested a review from gangwgr February 4, 2026 10:53
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 4, 2026
@p0lyn0mial p0lyn0mial requested review from ardaguclu and removed request for gangwgr February 4, 2026 10:53
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 4, 2026

@p0lyn0mial: This pull request references CNTRLPLANE-2247 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

we changed the function in #2112 but we forgot to update the signature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@p0lyn0mial p0lyn0mial requested a review from gangwgr February 4, 2026 10:53
@openshift-ci openshift-ci bot requested review from dgrisonnet and tkashem February 4, 2026 10:53
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2026
@ardaguclu
Copy link
Copy Markdown
Member

I intentionally didn't change the signature in case we'll need a cleanup function in the future. But we define it when it is needed
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
… signature of the DeployUpstreamMockKMSPlugin fn
@p0lyn0mial p0lyn0mial force-pushed the kms-upstream-plugin-cleanup branch from 62d2290 to cb5b3e4 Compare February 4, 2026 10:59
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@ardaguclu
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 4, 2026

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b7d4fa0 into openshift:master Feb 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants