Add controller-runtime based tls pkg

[damdo]

DEPRECATED. See openshift/controller-runtime-common#2 instead

--

This PR adds:

• a pkg/controllerruntime subfolder for controllerruntime based operators
• a tls pkg underneath controllerruntime, to deal with (centralized) TLS configuration in controller-runtime based operators

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damdo
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bertinatto]

I'm a bit worried about adding controller-runtime as a dependency, since it would become a transitive dependency for openshift/kubernetes. Is there an alternative place to add this controller?

[damdo]

Hey @bertinatto yes this was on my mind when I opened this PR and something @joelanford also brought up.
We are discussing this here: https://redhat-internal.slack.com/archives/C098FU5MRAB/p1768920412111089?thread_ts=1768846936.551799&cid=C098FU5MRAB

[p0lyn0mial]

library-go has an established controller style built on client-go.

Adding a dependency on controller-runtime or introducing new controllers based on that framework would be a significant shift and could create a parallel controller style.

If we need new controllers in library-go, it is better to implement them using the existing pattern. At the same time, library-go is a good place for shared helpers and utilities, and adding new helper functionality is fully in scope.

[damdo]

Thanks @p0lyn0mial I've replied to you here: https://redhat-internal.slack.com/archives/C098FU5MRAB/p1768990116222149?thread_ts=1768846936.551799&cid=C098FU5MRAB PTAL

[openshift-ci]

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[damdo]

/hold

It is very likely we are going to put this in a different repository, we'll discuss and make a decision on this, today at the OCP arch call.

[p0lyn0mial]

It is very likely we are going to put this in a different repository, we'll discuss and make a decision on this, today at the OCP arch call.

@damdo any update on ^ ?

[damdo]

Hey @p0lyn0mial yes, we have created the new repo and the PR is now up there: openshift/controller-runtime-common#2

We can close this off now

/close

[openshift-ci]

@damdo: Closed this PR.

Details

In response to this:

Hey @p0lyn0mial yes, we have created the new repo and the PR is now up there: openshift/controller-runtime-common#2

We can close this off now

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.