OCPBUGS-42083: Include bootstrap IP in etcd endpoints list

[vrutkovs]

During bootstrap kube-apiserver points to master etcd instances. These instances are being added to etcd-servers list one by one, to ensure that if any master can't reach some other etcds this revision
won't block the entire rollout.
However, at some point the masters may end up with just one etcd
(localhost and its IP), which makes it non-HA and apiserver may
lose etcd connection if this etcd is being reconfigured.

This change updates the list to include bootstrap etcd so that any master would always have an etcd instance to connect to.

Tested in openshift/cluster-kube-apiserver-operator#1745

[openshift-ci-robot]

@vrutkovs: This pull request references Jira Issue OCPBUGS-42083, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

During bootstrap kube-apiserver points to master etcd instances. These instances are being added to etcd-servers list one by one, to ensure that if any master can't reach some other etcds this revision
won't block the entire rollout.
However, at some point the masters may end up with just one etcd
(localhost and its IP), which makes it non-HA and apiserver may
lose etcd connection if this etcd is being reconfigured.

This change updates the list to include bootstrap etcd so that any master would always have an etcd instance to connect to.

Tested in openshift/cluster-kube-apiserver-operator#1745

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vrutkovs]

/jira refresh

[openshift-ci-robot]

@vrutkovs: This pull request references Jira Issue OCPBUGS-42083, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tjungblu]

/lgtm

thanks!

[deads2k]

found the code that removes this after bootstrapping: https://github.com/openshift/cluster-etcd-operator/blob/72555433bbf7bdb9ce5f8d93c3f49375c2770f0a/pkg/operator/etcdendpointscontroller/etcdendpointscontroller.go#L100-L105

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, tjungblu, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/operator/configobserver/etcd/OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@vrutkovs: Jira Issue OCPBUGS-42083: Some pull requests linked via external trackers have merged:

• openshift/library-go#1807

The following pull requests linked via external trackers have not merged:

• openshift/cluster-kube-apiserver-operator#1743 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-42083 has not been moved to the MODIFIED state.

Details

In response to this:

During bootstrap kube-apiserver points to master etcd instances. These instances are being added to etcd-servers list one by one, to ensure that if any master can't reach some other etcds this revision
won't block the entire rollout.
However, at some point the masters may end up with just one etcd
(localhost and its IP), which makes it non-HA and apiserver may
lose etcd connection if this etcd is being reconfigured.

This change updates the list to include bootstrap etcd so that any master would always have an etcd instance to connect to.

Tested in openshift/cluster-kube-apiserver-operator#1745

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vrutkovs]

/cherrypick release-4.17

[openshift-cherrypick-robot]

@vrutkovs: new pull request created: #1814

Details

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.