Skip to content

OCPBUGS-42083: library-go bump#1745

Closed
vrutkovs wants to merge 3 commits intoopenshift:masterfrom
vrutkovs:three-endpoints-and-bootstrap
Closed

OCPBUGS-42083: library-go bump#1745
vrutkovs wants to merge 3 commits intoopenshift:masterfrom
vrutkovs:three-endpoints-and-bootstrap

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Sep 27, 2024

Hold revision rollouts until we collect three etcd endpoints (localhost,
local IP and any other). This ensures that kube-apiserver has another
etcd to connect to when local instance is being reconfigured.

This functionality is skipped in control plane uses single replica
topology

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Sep 27, 2024

/test e2e-azure-ovn

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Sep 27, 2024

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.17-e2e-azure-ovn-kube-apiserver-rollout 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2024

@vrutkovs: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.17-e2e-azure-ovn-kube-apiserver-rollout

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4117ae80-7cc4-11ef-95a3-08b676707915-0

@vrutkovs vrutkovs mentioned this pull request Sep 27, 2024
Merged
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Sep 27, 2024

/payload 4.18 nightly blocking

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2024

@vrutkovs: trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b1a80120-7ce4-11ef-9eb0-1ba8f522c344-0

@vrutkovs vrutkovs force-pushed the three-endpoints-and-bootstrap branch from 7a303b3 to 43c1513 Compare September 30, 2024 14:51
@vrutkovs vrutkovs changed the title WIP include bootstrap IP in etcd endpoints OCPBUGS-42083: include bootstrap IP in etcd endpoints Sep 30, 2024
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 30, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 30, 2024

@vrutkovs: This pull request references Jira Issue OCPBUGS-42083, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Hold revision rollouts until we collect three etcd endpoints (localhost,
local IP and any other). This ensures that kube-apiserver has another
etcd to connect to when local instance is being reconfigured.

This functionality is skipped in control plane uses single replica
topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from wangke19 September 30, 2024 14:52
@vrutkovs vrutkovs changed the title OCPBUGS-42083: include bootstrap IP in etcd endpoints OCPBUGS-42083: library-go bump Sep 30, 2024
@vrutkovs vrutkovs force-pushed the three-endpoints-and-bootstrap branch from 43c1513 to 2b35bd4 Compare September 30, 2024 15:23
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 30, 2024

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 2b35bd4 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-metal-single-node-live-iso 2b35bd4 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-gcp-operator-single-node 2b35bd4 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2024
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Oct 1, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vrutkovs vrutkovs closed this Oct 1, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 1, 2024

@vrutkovs: This pull request references Jira Issue OCPBUGS-42083. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Hold revision rollouts until we collect three etcd endpoints (localhost,
local IP and any other). This ensures that kube-apiserver has another
etcd to connect to when local instance is being reconfigured.

This functionality is skipped in control plane uses single replica
topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@hexfusion hexfusion Awaiting requested review from hexfusion

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vrutkovs @openshift-ci-robot @openshift-merge-robot