Skip to content

OCPBUGS-30304: [release-4.15] certrotation: update all secret types to kubernetes.io/tls preserving existing content#1688

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:release-4.15from
vrutkovs:4.15-signer-rotate-preserve-type
Mar 6, 2024
Merged

OCPBUGS-30304: [release-4.15] certrotation: update all secret types to kubernetes.io/tls preserving existing content#1688
openshift-merge-bot[bot] merged 3 commits intoopenshift:release-4.15from
vrutkovs:4.15-signer-rotate-preserve-type

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Mar 6, 2024

Cherrypick of #1681 on release-4.15

Vadim Rutkovsky added 3 commits March 6, 2024 17:05
certrotation: replace JiraComponent/Description with AdditionalMetada…
2b9efa5 
…ta struct

Function signature won't require changes when new cert requirements are being created
certrotation: update all secret types to kubernetes.io/tls preservi…
d43b3a4 
…ng existing content

Pre-4.7 clusters had `SecretTypeTLS` type set, so on 4.15 upgrade these clusters had the secret delete and recreated. This commit will ensure these are being created without cert and key being regenerated
certrotation: use shared metadata update code for signer and target s…
c27c771 
…ecrets
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 6, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 6, 2024

@vrutkovs: This pull request references Jira Issue OCPBUGS-30304, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30119 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Cherrypick of #1681 on release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs vrutkovs mentioned this pull request Mar 6, 2024
Merged
@openshift-ci openshift-ci Bot requested review from deads2k and stlaz March 6, 2024 16:13
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 6, 2024

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Mar 6, 2024

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 6, 2024

@vrutkovs: This pull request references Jira Issue OCPBUGS-30304, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30119 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson sdodson added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 6, 2024
@benluddy
Copy link
Copy Markdown
Contributor

benluddy commented Mar 6, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: benluddy, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 206f66c into openshift:release-4.15 Mar 6, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 6, 2024

@vrutkovs: Jira Issue OCPBUGS-30304: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-30304 has not been moved to the MODIFIED state.

Details

In response to this:

Cherrypick of #1681 on release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Mar 7, 2024

Fix included in accepted release 4.15.0-0.nightly-2024-03-07-174330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@benluddy benluddy

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@vrutkovs @openshift-ci-robot @benluddy @openshift-merge-robot @sdodson @kasturinarra @zhouying7780 @xingxingxia @wangke19 @gangwgr