OCPBUGS-30304: cert rotation: Bump library-go to latest master by vrutkovs · Pull Request #1653 · openshift/cluster-kube-apiserver-operator

vrutkovs · 2024-03-06T10:41:38Z

Cherrypick of #1651 on 4.15

vrutkovs · 2024-03-06T10:41:56Z

/jira cherrypick OCPBUGS-30119

openshift-ci-robot · 2024-03-06T10:43:05Z

@vrutkovs: Jira Issue OCPBUGS-30119 has been cloned as Jira Issue OCPBUGS-30304. Will retitle bug to link to clone.
/retitle OCPBUGS-30304: [release-4.15] Bump library-go to latest master

Details

In response to this:

/jira cherrypick OCPBUGS-30119

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-03-06T10:43:23Z

@vrutkovs: This pull request references Jira Issue OCPBUGS-30304, which is invalid:

expected dependent Jira Issue OCPBUGS-30119 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Cherrypick of #1651 on 4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mfojtik · 2024-03-06T12:31:42Z

/lgtm

deads2k · 2024-03-06T15:49:35Z

-	github.com/openshift/client-go v0.0.0-20230926161409-848405da69e1
-	github.com/openshift/library-go v0.0.0-20231130112926-2285c05489d7
+	github.com/openshift/client-go v0.0.0-20231218140158-47f6d749b9d9
+	github.com/openshift/library-go v0.0.0-20240305144041-18ee8279b4e3


/hold

this is bringing 4.16 library-go into 4.15 kube-apiserver-operator. Unless or until we need to update client-go from an unsupported level, this should remain in sync

My fault, openshift/library-go#1688 is 4.15 cherrypick for library-go

vrutkovs · 2024-03-06T17:58:58Z

/hold cancel

wallylewis · 2024-03-06T17:59:24Z

/jira refresh

openshift-ci-robot · 2024-03-06T17:59:30Z

@wallylewis: This pull request references Jira Issue OCPBUGS-30304, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.z) matches configured target version for branch (4.15.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-30119 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-30119 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
bug has dependents

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sdodson · 2024-03-06T18:09:56Z

/retest-required

benluddy · 2024-03-06T22:17:39Z

+	k8s.io/api v0.29.0
+	k8s.io/apiextensions-apiserver v0.29.0
+	k8s.io/apimachinery v0.29.0
+	k8s.io/apiserver v0.29.0
+	k8s.io/client-go v0.29.0
+	k8s.io/component-base v0.29.0


Is this expected?

/hold

The bump commit looks like the result of bumping library-go to the current release-4.15 after bumping to 4.16 and tidying (all of the other dependency changes that came along with 4.16 were preserved). I see a one-line go.mod diff if I revert the other changes from accidental 4.16 bump first: benluddy@d1d767f#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

Updated
/hold cancel

openshift-ci · 2024-03-07T09:27:40Z

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node	`7f03359`	link	false	`/test e2e-aws-operator-disruptive-single-node`
ci/prow/e2e-gcp-operator-single-node	`7f03359`	link	false	`/test e2e-gcp-operator-single-node`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

benluddy · 2024-03-07T13:47:31Z

/lgtm

openshift-ci · 2024-03-07T13:55:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, mfojtik, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [benluddy,mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-03-07T13:59:49Z

@vrutkovs: Jira Issue OCPBUGS-30304: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30304 has been moved to the MODIFIED state.

Details

In response to this:

Cherrypick of #1651 on 4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-03-07T16:20:38Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.15.0-202403071539.p0.g9fe0ab1.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator.
All builds following this will include this PR.

openshift-merge-robot · 2024-03-07T23:41:32Z

Fix included in accepted release 4.15.0-0.nightly-2024-03-07-174330

openshift-ci Bot changed the title ~~[release-4.15] Bump library-go to latest master~~ OCPBUGS-30304: [release-4.15] Bump library-go to latest master Mar 6, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 6, 2024

openshift-ci Bot requested review from benluddy and dgrisonnet March 6, 2024 10:43

vrutkovs force-pushed the 4.15-bump-library-go-mar05 branch 2 times, most recently from f0fe199 to f8ad97a Compare March 6, 2024 11:30

mfojtik added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 6, 2024

openshift-ci Bot assigned gangwgr, wangke19 and xingxingxia Mar 6, 2024

openshift-ci Bot assigned mfojtik Mar 6, 2024

openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 6, 2024

deads2k reviewed Mar 6, 2024

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024

openshift-ci-robot mentioned this pull request Mar 6, 2024

OCPBUGS-30304: [release-4.15] certrotation: update all secret types to kubernetes.io/tls preserving existing content openshift/library-go#1688

Merged

vrutkovs force-pushed the 4.15-bump-library-go-mar05 branch from f8ad97a to 1648c7f Compare March 6, 2024 17:58

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 6, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 6, 2024

openshift-ci Bot requested a review from wangke19 March 6, 2024 17:59

vrutkovs force-pushed the 4.15-bump-library-go-mar05 branch from 1648c7f to 11f4bf6 Compare March 6, 2024 18:28

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 6, 2024

sdodson changed the title ~~OCPBUGS-30304: [release-4.15] Bump library-go to latest master~~ OCPBUGS-30304: cert rotation: Bump library-go to latest master Mar 6, 2024

benluddy reviewed Mar 6, 2024

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024

vrutkovs force-pushed the 4.15-bump-library-go-mar05 branch from 11f4bf6 to 774dfdd Compare March 7, 2024 06:22

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024

Vadim Rutkovsky and others added 2 commits March 7, 2024 07:52

Bump library-go to latest release-4.15

d232d25

Fix cert additional annotations changes

7f03359

vrutkovs force-pushed the 4.15-bump-library-go-mar05 branch from 774dfdd to 7f03359 Compare March 7, 2024 06:53

openshift-ci Bot assigned benluddy Mar 7, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024

openshift-merge-bot Bot merged commit 9fe0ab1 into openshift:release-4.15 Mar 7, 2024

vrutkovs mentioned this pull request Mar 11, 2024

cluster dead after a several days after upgrading to 4.15.0-0.okd-2024-01-27-070424 okd-project/okd#1881

Closed

Conversation

vrutkovs commented Mar 6, 2024

Uh oh!

vrutkovs commented Mar 6, 2024

Uh oh!

openshift-ci-robot commented Mar 6, 2024

Uh oh!

openshift-ci-robot commented Mar 6, 2024

Uh oh!

mfojtik commented Mar 6, 2024

Uh oh!

deads2k Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

vrutkovs Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

vrutkovs Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

vrutkovs commented Mar 6, 2024

Uh oh!

wallylewis commented Mar 6, 2024

Uh oh!

openshift-ci-robot commented Mar 6, 2024

Uh oh!

sdodson commented Mar 6, 2024

Uh oh!

benluddy Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

benluddy Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

vrutkovs Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Mar 7, 2024

Uh oh!

benluddy commented Mar 7, 2024

Uh oh!

openshift-ci Bot commented Mar 7, 2024

Uh oh!

openshift-ci-robot commented Mar 7, 2024

Uh oh!

openshift-bot commented Mar 7, 2024

Uh oh!

openshift-merge-robot commented Mar 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants