Skip to content

Bug 1896558: Bump to use k8s/apiserver openshift fork #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
damemi wants to merge 2 commits into from
Closed

Bug 1896558: Bump to use k8s/apiserver openshift fork #1008

damemi wants to merge 2 commits into from

Conversation

@damemi
Copy link

@damemi damemi commented Mar 9, 2021 •
edited
Loading

This bumps and reacts to the changes in https://github.com/openshift/kubernetes/pull/558/files (pinning to openshift/kubernetes forks).

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 9, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damemi
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damemi damemi changed the title [wip] Bump upstream v0.21.0-beta.1 Bump to use k8s/apiserver openshift fork Mar 9, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2021
damemi
damemi commented Mar 9, 2021
View reviewed changes
Copy link
Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @sttts @mfojtik
With the changes from openshift/kubernetes#558 that added this parameter, do we want to wire true to these controllers in 7ea38ea?

@damemi damemi mentioned this pull request Mar 9, 2021
Closed
@damemi damemi changed the title Bump to use k8s/apiserver openshift fork Bug 1896558: Bump to use k8s/apiserver openshift fork Mar 10, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 10, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2021

@damemi: This pull request references Bugzilla bug 1896558, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @kasturinarra

Details

In response to this:

Bug 1896558: Bump to use k8s/apiserver openshift fork

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Mar 11, 2021

/hold

We cannot use o/k here. This library-go is used in many other places where we don't want to use a kube fork.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2021
@damemi damemi mentioned this pull request Mar 11, 2021
Merged
@damemi
Copy link
Author

damemi commented Mar 18, 2021

/close
we won't need this with openshift/kubernetes#616

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2021

@damemi: Closed this PR.

Details

In response to this:

/close
we won't need this with openshift/kubernetes#616

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2021

@damemi: This pull request references Bugzilla bug 1896558. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1896558: Bump to use k8s/apiserver openshift fork

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@sttts sttts Awaiting requested review from sttts

@mfojtik mfojtik Awaiting requested review from mfojtik

@kasturinarra kasturinarra Awaiting requested review from kasturinarra

Assignees

No one assigned

Labels

bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@damemi @openshift-ci-robot @sttts