UPSTREAM: <carry>: kube-apiserver: ignore SIGTERM/INT after the first one #616
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@damemi: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
There was a problem hiding this comment.
all the cases with true you can revert to be just server.SetupSignalHandler().
There was a problem hiding this comment.
would avoid copying code. You can do:
func SetupSignalContextNotExiting() context.Context {
return setupSignalContext(false)
}
func SetupSignalContext() context.Context {
return setupSignalContext(true)
}
func setupSignalContext(exitOnSecondSignal bool) context.Context {
...
}
|
@damemi: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
…ctions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go.
|
@sttts ping, squashed the commits here. Could you ptal? |
|
@damemi: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Looks like this still has |
|
It needs to be approved by a top-level approver I think? Maybe @smarterclayton could take a look? |
soltysh
removed
the
backports/unvalidated-commits
That's a novel thing - updated, should merge shortly. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test k8s-e2e-gcp |
|
/cherry-pick release-4.7 |
|
@damemi: new pull request created: #739 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
This partially reverts some of the changes from #558 to provide the new functions for areas that need them, while keeping the old functions so as to not affect other repos that depend on them (like library-go, see openshift/library-go#1008)