Skip to content

Conversation

@huffmanca
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

Backport of kubernetes#102021 . Corrects the snapshot tests to use volumeName instead of pv.Name when waiting for the NodeUnpublish calls.

Which issue(s) this PR fixes:

Fixes # https://bugzilla.redhat.com/show_bug.cgi?id=1913974

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 25, 2021
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 25, 2021
@openshift-ci-robot
Copy link

@huffmanca: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 25, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 25, 2021

@huffmanca: This pull request references Bugzilla bug 1913974, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 1913974: UPSTREAM: 102021: Update snapshotting tests to use volumeHandle for CSI volumes when waiting for NodeUnpublish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 25, 2021
@openshift-ci openshift-ci bot requested review from marun and soltysh May 25, 2021 12:11
@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels May 25, 2021
@openshift-ci-robot
Copy link

@huffmanca: the contents of this pull request could be automatically validated.

The following commits are valid:

@huffmanca
Copy link
Author

One note about the e2e-aws-csi tests - these come from openshift/origin, so this PR will have to be merged first before the flaking snapshot tests will pass.

@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@huffmanca
Copy link
Author

/retest

@smarterclayton
Copy link

/approve

@huffmanca
Copy link
Author

/assign @mfojtik

Can you take a look and approve this one?

@smarterclayton smarterclayton added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2021
@smarterclayton
Copy link

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: huffmanca, jsafrane, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fc33082 into openshift:master May 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 27, 2021

@huffmanca: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1913974 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1913974: UPSTREAM: 102021: Update snapshotting tests to use volumeHandle for CSI volumes when waiting for NodeUnpublish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants