-
Notifications
You must be signed in to change notification settings - Fork 129
Bug 1913974: UPSTREAM: 102021: Update snapshotting tests to use volumeHandle for CSI volumes when waiting for NodeUnpublish #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@huffmanca: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
@huffmanca: This pull request references Bugzilla bug 1913974, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…SI volumes when waiting for NodeUnpublish
|
@huffmanca: the contents of this pull request could be automatically validated. The following commits are valid: |
|
One note about the e2e-aws-csi tests - these come from openshift/origin, so this PR will have to be merged first before the flaking snapshot tests will pass. |
|
/lgtm |
|
/retest |
|
/approve |
|
/assign @mfojtik Can you take a look and approve this one? |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: huffmanca, jsafrane, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@huffmanca: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1913974 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Backport of kubernetes#102021 . Corrects the snapshot tests to use
volumeNameinstead ofpv.Namewhen waiting for the NodeUnpublish calls.Which issue(s) this PR fixes:
Fixes # https://bugzilla.redhat.com/show_bug.cgi?id=1913974
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: