Skip to content

UPSTREAM: 101280: Bug 1913974: Force NodeUnstageVolume to finish for all distros#700

Merged
smarterclayton merged 1 commit intoopenshift:masterfrom
huffmanca:bz1913974
Apr 30, 2021
Merged

UPSTREAM: 101280: Bug 1913974: Force NodeUnstageVolume to finish for all distros#700
smarterclayton merged 1 commit intoopenshift:masterfrom
huffmanca:bz1913974

Conversation

@huffmanca
Copy link

@huffmanca huffmanca commented Apr 22, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Backport of kubernetes#101280 - Forces NodeUnstageVolume to complete before we create a VolumeSnapshot for all distros in the e2e snapshot tests. It's currently possible for the CreateSnapshot to complete before the NodeUnstageVolume call, which can result in empty VolumeSnapshots being created, resulting in the test failing

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Apr 22, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2021

@huffmanca: This pull request references Bugzilla bug 1913974, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

UPSTREAM: 101280: Bug 1913974: Force NodeUnstageVolume to finish for all distros

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 22, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2021

@huffmanca: the contents of this pull request could be automatically validated.

The following commits are valid:

@huffmanca
Copy link
Author

huffmanca commented Apr 22, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 22, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2021

@huffmanca: This pull request references Bugzilla bug 1913974, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (piqin@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member

bertinatto commented Apr 22, 2021

/test e2e-azure-csi

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2021

@bertinatto: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test artifacts
  • /test configmap-scale
  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-downgrade
  • /test e2e-aws-fips
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-vsphere
  • /test images
  • /test integration
  • /test k8s-e2e-conformance-aws
  • /test k8s-e2e-gcp
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-commits

Use /test all to run the following jobs:

  • pull-ci-openshift-kubernetes-master-e2e-agnostic-cmd
  • pull-ci-openshift-kubernetes-master-e2e-aws-csi
  • pull-ci-openshift-kubernetes-master-e2e-aws-fips
  • pull-ci-openshift-kubernetes-master-e2e-aws-serial
  • pull-ci-openshift-kubernetes-master-e2e-gcp
  • pull-ci-openshift-kubernetes-master-e2e-gcp-upgrade
  • pull-ci-openshift-kubernetes-master-images
  • pull-ci-openshift-kubernetes-master-integration
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-master-unit
  • pull-ci-openshift-kubernetes-master-verify
  • pull-ci-openshift-kubernetes-master-verify-commits
Details

In response to this:

/test e2e-azure-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@huffmanca
Copy link
Author

huffmanca commented Apr 22, 2021

/test e2e-aws-csi

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2021

@huffmanca: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test artifacts
  • /test configmap-scale
  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-downgrade
  • /test e2e-aws-fips
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-vsphere
  • /test images
  • /test integration
  • /test k8s-e2e-conformance-aws
  • /test k8s-e2e-gcp
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-commits

Use /test all to run the following jobs:

  • pull-ci-openshift-kubernetes-master-e2e-agnostic-cmd
  • pull-ci-openshift-kubernetes-master-e2e-aws-csi
  • pull-ci-openshift-kubernetes-master-e2e-aws-fips
  • pull-ci-openshift-kubernetes-master-e2e-aws-serial
  • pull-ci-openshift-kubernetes-master-e2e-gcp
  • pull-ci-openshift-kubernetes-master-e2e-gcp-upgrade
  • pull-ci-openshift-kubernetes-master-images
  • pull-ci-openshift-kubernetes-master-integration
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-master-unit
  • pull-ci-openshift-kubernetes-master-verify
  • pull-ci-openshift-kubernetes-master-verify-commits
Details

In response to this:

/test ci/prow/e2e-aws-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member

bertinatto commented Apr 23, 2021

/test e2e-aws-csi

@jsafrane
Copy link

jsafrane commented Apr 23, 2021

/retest

@jsafrane
Copy link

jsafrane commented Apr 23, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2021
@jsafrane
Copy link

jsafrane commented Apr 26, 2021

/retest

soltysh
soltysh approved these changes Apr 27, 2021
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@soltysh
Copy link

soltysh commented Apr 27, 2021

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, jsafrane, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@openshift-bot
Copy link

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@huffmanca
Copy link
Author

huffmanca commented Apr 27, 2021

/retest

@bertinatto
Copy link
Member

bertinatto commented Apr 28, 2021

/test e2e-gcp-upgrade

@huffmanca
Copy link
Author

huffmanca commented Apr 28, 2021

/retest

@openshift-bot
Copy link

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@bertinatto
Copy link
Member

bertinatto commented Apr 29, 2021

/retest

1 similar comment
@huffmanca
Copy link
Author

huffmanca commented Apr 29, 2021

/retest

@openshift-bot
Copy link

openshift-bot commented Apr 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

openshift-bot commented Apr 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 30, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 30, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 30, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link

smarterclayton commented Apr 30, 2021

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kubernetes/700/pull-ci-openshift-kubernetes-master-e2e-aws-csi/1387921811835981824 appears to have failed with the test that this allegedly fixes?

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Apr 30, 2021 •
edited
Loading

@huffmanca: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-csi ad4f896 link /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link

jsafrane commented Apr 30, 2021

@smarterclayton e2e-aws-csi uses openshift-tests, which comes from openshift/origin, not from openshift/kubernetes.

@smarterclayton
Copy link

smarterclayton commented Apr 30, 2021

right - thanks

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2021
@huffmanca
Copy link
Author

huffmanca commented Apr 30, 2021

/retest

@smarterclayton smarterclayton merged commit d76abf4 into openshift:master Apr 30, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2021

@huffmanca: All pull requests linked via external trackers have merged:

Bugzilla bug 1913974 has been moved to the MODIFIED state.

Details

In response to this:

UPSTREAM: 101280: Bug 1913974: Force NodeUnstageVolume to finish for all distros

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton
Copy link

smarterclayton commented Apr 30, 2021

Can you open the origin bump now?

@huffmanca huffmanca mentioned this pull request Apr 30, 2021
Closed
@huffmanca
Copy link
Author

huffmanca commented Apr 30, 2021

@smarterclayton ,

We need openshift/origin#26054 to land first. I opened two PRs, both based on soltysh's PR, depending on how you'd prefer it look:

  1. Bug 1913974: Bump snapshot tests origin#26125 - this PR includes ad4f896 as a patch, and modifies no other files.
  2. Bug 1913974: Bump kubernetes to the latest version of openshift/kubernetes origin#26126 - this PR bumps the k8s dependency to use the latest version of openshift/kubernetes, which includes ad4f896 .

This was referenced May 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marun marun Awaiting requested review from marun

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@huffmanca @openshift-ci-robot @bertinatto @jsafrane @soltysh @openshift-bot @smarterclayton