OCPBUGS-59534: Rebase v1.32.7 to 4.19 #2367
Conversation
Once received job deletion event, it cleans the backoff records for that job before enqueueing this job so that we can avoid a race condition that the syncJob() may incorrect use stale backoff records for a newly created job with same key. Co-authored-by: Michal Wozniak <[email protected]>
…pick-of-#132109-release-1.32 Automated cherry pick of kubernetes#132109: Clean backoff record earlier
Writes to policy resources don't instantaneously take effect in admission. ValidatingAdmissionPolicy integration tests determine that the policies under test have taken effect by adding a sentinel policy rule and polling until that rule is applied to a request. If the marker resource names are the same for each test case in a series of test cases, then observing a policy's effect on a marker request only indicates that _any_ test policy is in effect, but it's not necessarily the policy the current test case is waiting for. For example: 1. Test 1 creates a policy and binding. 2. The policy and binding are observed by the admission plugin and take effect. 3. Test 1 observes that a policy is in effect via marker requests. 4. Test 1 exercises the behavior under test and successfully deletes the policy and binding it created. 5. Test 2 creates a policy and binding. 6. Test 2 observes that a policy is in effect via marker requests, but the policy in effect is still the one created by Test 1. 7. Test 2 exercises the behavior under test, which fails because it was evaluated against Test 1's policy. Generating a per-policy name for the marker resource in each test resolves the timing issue. In the example, step (6) will not proceed until the admission plugin has observed the policy and binding created in (5).
…k-of-#132502-upstream-release-1.32 Automated cherry pick of kubernetes#132502: Fix flake caused by invalid detection of active policies in VAP integration tests
…k-of-#132614-upstream-release-1.32 Automated cherry pick of kubernetes#132614: Fix validation for Job with suspend=true,completions=0 to set Complete condition
…ick-of-#131251-origin-release-1.32 Automated cherry pick of kubernetes#131251: fix(kubelet): acquire imageRecordsLock when removing image
…pick-of-#130782-origin-release-1.32 Automated cherry pick of kubernetes#130782: Kubeadm issue kubernetes#3152 ControlPlane node setup failing with "etcdserver: can only promote a learner member"
Kubernetes official release v1.32.7
openshift-ci-robot
added
backports/unvalidated-commits
|
@dusk125: This pull request references Jira Issue OCPBUGS-59534, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dusk125: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/jira refresh |
|
@dusk125: This pull request references Jira Issue OCPBUGS-59534, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/override ci/prow/configmap-scale |
|
@dusk125: dusk125 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/test okd-scos-e2e-aws-ovn |
|
@dusk125: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/remove-label backports/unvalidated-commits |
openshift-ci
bot
added
jira/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, dusk125, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
duanwei33,
gangwgr,
kasturinarra,
lyman9966,
wangke19,
xingxingxia and
zhouying7780
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel 4.20 bump has merged |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 138db52
into
openshift:release-4.19
|
@dusk125: Jira Issue OCPBUGS-59534: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-59534 has been moved to the MODIFIED state. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
|
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
|
Fix included in accepted release 4.19.0-0.nightly-2025-08-07-041315 |
20 participants
No description provided.