Skip to content

Automated cherry pick of #132109: Clean backoff record earlier #132159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jul 9, 2025
Merged

Automated cherry pick of #132109: Clean backoff record earlier #132159

k8s-ci-robot merged 1 commit into from
Jul 9, 2025

Conversation

@linxiulei
Copy link
Contributor

@linxiulei linxiulei commented Jun 6, 2025

Cherry pick of #132109 on release-1.32.

#132109: Clean backoff record earlier

For details on the cherry pick process, see the cherry pick requests page.

Fix a bug causing unexpected delay of creating pods for newly created jobs

@linxiulei @mimowo
Clean backoff record earlier
62eb11d 
Once received job deletion event, it cleans the backoff records for that
job before enqueueing this job so that we can avoid a race condition
that the syncJob() may incorrect use stale backoff records for a newly created
job with same key.

Co-authored-by: Michal Wozniak <[email protected]>
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jun 6, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 6, 2025
@k8s-ci-robot k8s-ci-robot requested review from kow3ns and krmayankk June 6, 2025 20:51
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 6, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jun 6, 2025
@linxiulei
Copy link
Contributor Author

linxiulei commented Jun 6, 2025

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team June 6, 2025 21:00
@mimowo
Copy link
Contributor

mimowo commented Jun 6, 2025 •
edited
Loading

/lgtm
/approve
As a Job maintainer.

For justification see comment.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 6, 2025

LGTM label has been added.

DetailsGit tree hash: 495007d2c09a6eb2b9e8f00c66342bf2813a1237

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2025
@mimowo
Copy link
Contributor

mimowo commented Jun 6, 2025

/test pull-kubernetes-unit
This is infra flake: There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (0/92 nodes are available: 11 node(s) had untolerated taint {node.kubernetes.io/not-ready: }, 19 Insufficient memory, 3 node(s) had untolerated taint {dedicated: sig-node}, 70 Insufficient cpu, 8 node(s) had untolerated taint {kubernetes.io/arch: arm64}. preemption: 0/92 nodes are available: 22 Preemption is not helpful for scheduling, 70 No preemption victims found for incoming pod.)

@linxiulei
Copy link
Contributor Author

linxiulei commented Jun 6, 2025

/retest

@atiratree
Copy link
Member

atiratree commented Jun 6, 2025

/kind bug
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 6, 2025
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 6, 2025
@cici37
Copy link
Contributor

cici37 commented Jul 8, 2025

/assign @kubernetes/release-managers
As a critical bug fix, it makes sense to me to cherry pick this fix.

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 9, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linxiulei, mimowo, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mimowo
Copy link
Contributor

mimowo commented Jul 9, 2025

/test pull-kubernetes-e2e-kind-ipv6
"Kubernetes e2e suite: [It] [sig-cli] Kubectl Port forwarding with a pod being removed should stop port-forwarding " is not related

@mimowo
Copy link
Contributor

mimowo commented Jul 9, 2025

I think it cannot get merged because there is an issue on the release branch, reported here: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1752043658543029

@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 9, 2025

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 9, 2025

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@cici37
Copy link
Contributor

cici37 commented Jul 9, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5b6a01c into kubernetes:release-1.32 Jul 9, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@mimowo mimowo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Apps
Archived in project

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

7 participants

@linxiulei @mimowo @k8s-ci-robot @atiratree @cici37 @k8s-triage-robot @saschagrunert