Skip to content

UPSTREAM:<carry>:Unskip OCP SDN related tests#1201

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
astoycos:activate-netpol-sdn
Mar 15, 2022
Merged

UPSTREAM:<carry>:Unskip OCP SDN related tests#1201
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
astoycos:activate-netpol-sdn

Conversation

@astoycos
Copy link

@astoycos astoycos commented Mar 2, 2022

Unskip networkPolicy tests concerning IpBlock and
egress rules since both features have now been
implemented.

https://issues.redhat.com/browse/SDN-51
And
openshift/sdn@8334f80

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 2, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 2, 2022

@astoycos: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@astoycos
Copy link
Author

astoycos commented Mar 2, 2022

/assign @danwinship

@openshift-ci openshift-ci bot requested review from marun and soltysh March 2, 2022 22:12
@bpickard22
Copy link

bpickard22 commented Mar 2, 2022 •
edited
Loading

/assign @bpickard22

@astoycos
Copy link
Author

astoycos commented Mar 3, 2022

/test all

@danwinship danwinship mentioned this pull request Mar 3, 2022
Closed
@astoycos astoycos force-pushed the activate-netpol-sdn branch from 6aaccbb to 74fface Compare March 3, 2022 21:24
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 3, 2022

@astoycos: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@astoycos
UPSTREAM: <carry>: Unskip OCP SDN related tests
aba8d20 
Unskip networkPolicy tests concerning IpBlock and
egress rules since both features have now been
implemented.

Signed-off-by: astoycos <astoycos@redhat.com>
@astoycos astoycos force-pushed the activate-netpol-sdn branch from 74fface to aba8d20 Compare March 3, 2022 21:42
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 3, 2022

@astoycos: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@astoycos
Copy link
Author

astoycos commented Mar 4, 2022

/test all

@astoycos
Copy link
Author

astoycos commented Mar 4, 2022

/retest

3 similar comments
@astoycos
Copy link
Author

astoycos commented Mar 4, 2022

/retest

@astoycos
Copy link
Author

astoycos commented Mar 7, 2022

/retest

@astoycos
Copy link
Author

astoycos commented Mar 7, 2022

/retest

@astoycos
Copy link
Author

astoycos commented Mar 7, 2022

Things look pretty good here @danwinship

@danwinship
Copy link

danwinship commented Mar 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2022
@astoycos
Copy link
Author

astoycos commented Mar 8, 2022

/assign @soltysh

soltysh
soltysh approved these changes Mar 14, 2022
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/label backports/validated-commits
/remove-label backports/unvalidated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Mar 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, danwinship, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@openshift-bot
Copy link

openshift-bot commented Mar 14, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link

openshift-bot commented Mar 14, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Mar 14, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Mar 14, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Mar 14, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Mar 14, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Mar 15, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Mar 15, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Mar 15, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Mar 15, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2022

@astoycos: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d67dd91 into openshift:master Mar 15, 2022
@stbenjam stbenjam mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marun marun Awaiting requested review from marun

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danwinship danwinship

@soltysh soltysh

@bpickard22 bpickard22

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@astoycos @openshift-ci-robot @bpickard22 @danwinship @openshift-bot @soltysh @openshift-merge-robot

Comments