Skip to content

Backports 96217, 95725, 95002 and 96424#23

Merged
sttts merged 4 commits intoopenshift:openshift-apiserver-4.5-kubernetes-1.18.9from
p0lyn0mial:o/openshift-apiserver-4.5-kubernetes-1.18.9-sar-tr-no-panic
Dec 9, 2020
Merged

Backports 96217, 95725, 95002 and 96424#23
sttts merged 4 commits intoopenshift:openshift-apiserver-4.5-kubernetes-1.18.9from
p0lyn0mial:o/openshift-apiserver-4.5-kubernetes-1.18.9-sar-tr-no-panic

Conversation

@p0lyn0mial
Copy link

@p0lyn0mial p0lyn0mial commented Dec 8, 2020

  • Default timeout (10 s) for the TokenReview client (96217)
  • Default timeout (10 s0) for the SubjectAccessReview client (95725)
  • No stack trace of aborted requests in the logs (95002 and 96424)

For openshift-apiserver and oauth-server

Note:
I had minor issues back porting 95002 and 96424.
Also, I had to removed klogv2 imports (in 95002 and 96424) since it was added in 4.6

…logs

Aborted requests are the ones that were disrupted with http.ErrAbortHandler.
For example, the timeout handler will panic with http.ErrAbortHandler when a response to the client has been already sent
and the timeout elapsed.

Additionally, a new metric requestAbortsTotal was defined to count aborted requests. The new metric allows for aggregation for each group, version, verb, resource, subresource and scope.
@p0lyn0mial
Copy link
Author

/assign @sttts

@sttts
Copy link

sttts commented Dec 9, 2020

/lgtm
/approve

@sttts sttts merged commit 543a104 into openshift:openshift-apiserver-4.5-kubernetes-1.18.9 Dec 9, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments