Bug 1809647: Align with latest changes upstream by elfosardo · Pull Request #29 · openshift/ironic-inspector-image

elfosardo · 2020-03-03T15:35:08Z

Convert to dnf
Completely remove mdns configuration
Remove sqlite after usage
Remove iptables filters

Related changes in metal3-io
metal3-io#37
metal3-io#39
metal3-io#41
metal3-io#44

Convert to dnf Completely remove mdns configuration Remove sqlite after usage Remove iptables filters

openshift-ci-robot · 2020-03-03T15:35:09Z

@elfosardo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Align with latest changes upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-03T15:35:42Z

@elfosardo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Align with latest changes upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-03T15:40:16Z

@elfosardo: This pull request references Bugzilla bug 1809645, which is invalid:

expected Bugzilla bug 1809645 to depend on a bug targeting the "4.5.0" release and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1809645: Align with latest changes upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-03T15:44:40Z

@elfosardo: This pull request references Bugzilla bug 1809647, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected dependent Bugzilla bug 1809645 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1809647: Align with latest changes upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elfosardo · 2020-03-03T15:45:47Z

/bugzilla refresh

openshift-ci-robot · 2020-03-03T15:45:51Z

@elfosardo: This pull request references Bugzilla bug 1809647, which is invalid:

expected Bugzilla bug 1809647 to depend on a bug targeting the "4.5.0" release and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elfosardo · 2020-03-03T15:47:20Z

/bugzilla refresh

openshift-ci-robot · 2020-03-03T15:47:23Z

@elfosardo: This pull request references Bugzilla bug 1809647, which is invalid:

expected Bugzilla bug 1809647 to depend on a bug targeting the "4.5.0" release and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elfosardo · 2020-03-03T15:49:00Z

/bugzilla refresh

openshift-ci-robot · 2020-03-03T15:50:09Z

@elfosardo: This pull request references Bugzilla bug 1809647, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.0) matches configured target release for branch (4.4.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1809645 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1809645 targets the "4.5.0" release, matching the expected (4.5.0) release
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-03-03T16:03:01Z

/lgtm

stbenjam · 2020-03-03T16:03:28Z

/hold

stbenjam · 2020-03-03T16:05:30Z

Remove the hold when you're ready for it to be merged, but looks like there's still discussion on the 4.5/master branch PR about cherry-picking.

openshift-ci-robot · 2020-03-03T16:23:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [elfosardo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

elfosardo · 2020-03-03T16:32:08Z

@stbenjam thanks, #28 was merged as-is, so I'm going to unhold this one too

elfosardo · 2020-03-03T16:32:15Z

/unhold

openshift-ci-robot · 2020-03-03T16:36:57Z

@elfosardo: All pull requests linked via external trackers have merged. Bugzilla bug 1809647 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1809647: Align with latest changes upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Align with latest changes upstream

fe53744

Convert to dnf Completely remove mdns configuration Remove sqlite after usage Remove iptables filters

elfosardo requested review from dtantsur, hardys and stbenjam March 3, 2020 15:35

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2020

elfosardo changed the title ~~Align with latest changes upstream~~ Bug 1809645: Align with latest changes upstream Mar 3, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 3, 2020

elfosardo changed the title ~~Bug 1809645: Align with latest changes upstream~~ Bug 1809647: Align with latest changes upstream Mar 3, 2020

openshift-ci-robot requested a review from russellb March 3, 2020 15:45

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 3, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 3, 2020

openshift-ci-robot assigned stbenjam Mar 3, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020

openshift-merge-robot merged commit 3dafdd9 into openshift:release-4.4 Mar 3, 2020

Conversation

elfosardo commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 3, 2020

Uh oh!

openshift-ci-robot commented Mar 3, 2020

Uh oh!

openshift-ci-robot commented Mar 3, 2020

Uh oh!

openshift-ci-robot commented Mar 3, 2020

Uh oh!

elfosardo commented Mar 3, 2020

Uh oh!

openshift-ci-robot commented Mar 3, 2020

Uh oh!

elfosardo commented Mar 3, 2020

Uh oh!

openshift-ci-robot commented Mar 3, 2020

Uh oh!

elfosardo commented Mar 3, 2020

Uh oh!

openshift-ci-robot commented Mar 3, 2020

Uh oh!

stbenjam commented Mar 3, 2020

Uh oh!

stbenjam commented Mar 3, 2020

Uh oh!

stbenjam commented Mar 3, 2020

Uh oh!

openshift-ci-robot commented Mar 3, 2020

Uh oh!

elfosardo commented Mar 3, 2020

Uh oh!

elfosardo commented Mar 3, 2020

Uh oh!

openshift-ci-robot commented Mar 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

elfosardo commented Mar 3, 2020 •

edited

Loading