Skip to content
This repository was archived by the owner on Sep 29, 2021. It is now read-only.

Remove iptables filters from ironic-inspector containers#39

Merged
metal3-io-bot merged 1 commit into
metal3-io:masterfrom
derekhiggins:no-iptables
Nov 26, 2019
Merged

Remove iptables filters from ironic-inspector containers#39
metal3-io-bot merged 1 commit into
metal3-io:masterfrom
derekhiggins:no-iptables

Conversation

@derekhiggins
Copy link
Copy Markdown
Member

@derekhiggins derekhiggins commented Oct 10, 2019

We don't appear to need these, infact they output
errors on container startup...

@metal3-io-bot
Copy link
Copy Markdown
Collaborator

metal3-io-bot commented Oct 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2019
@derekhiggins
Copy link
Copy Markdown
Member Author

derekhiggins commented Oct 10, 2019

/hold
will run through ci once this merges openshift-metal3/dev-scripts#826

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2019
@russellb
Copy link
Copy Markdown
Member

russellb commented Oct 10, 2019

/lgtm

Tide should block merging until you remove the hold

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2019
@metal3ci
Copy link
Copy Markdown

metal3ci commented Oct 11, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1214/

@metal3ci
Copy link
Copy Markdown

metal3ci commented Oct 24, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1267/

@derekhiggins
Copy link
Copy Markdown
Member Author

derekhiggins commented Oct 25, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1267/

CI passed, the log retrieval at the end failed,
cp: cannot stat ‘/opt/dev-scripts/ironic/log’: No such file or directory

@derekhiggins
Remove iptables filters from ironic-inspector containers
aa77591 
We don't appear to need these, infact they output
errors on container startup...
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2019
@metal3ci
Copy link
Copy Markdown

metal3ci commented Nov 22, 2019

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1328/

@hardys hardys closed this Nov 25, 2019
@hardys hardys reopened this Nov 25, 2019
@hardys
Copy link
Copy Markdown
Member

hardys commented Nov 25, 2019

/unhold

@hardys
Copy link
Copy Markdown
Member

hardys commented Nov 25, 2019

@derekhiggins looks like perhaps you need to unhold or hold cancel this, lgtm when you're ready as it passed CI and I merged the similar change for ironic-image

@derekhiggins
Copy link
Copy Markdown
Member Author

derekhiggins commented Nov 25, 2019

/unhold

@elfosardo
Copy link
Copy Markdown
Member

elfosardo commented Nov 25, 2019

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2019
@hardys
Copy link
Copy Markdown
Member

hardys commented Nov 26, 2019

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2019
@metal3-io-bot metal3-io-bot merged commit 69bd048 into metal3-io:master Nov 26, 2019
This was referenced Mar 3, 2020
Merged
Merged
elfosardo pushed a commit to elfosardo/ironic-inspector-image that referenced this pull request Aug 4, 2020
@openshift-merge-robot
Merge pull request metal3-io#39 from zaneb/openshift/basic-auth
957271c 
Simplify HTTP basic auth configuration
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@russellb russellb

@hardys hardys

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. CI lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@derekhiggins @metal3-io-bot @russellb @metal3ci @hardys @elfosardo