-
Notifications
You must be signed in to change notification settings - Fork 46
Enable prometheus-exporter #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable prometheus-exporter #27
Conversation
|
/retest |
|
/retest |
|
/approve |
|
/retest |
|
retest |
|
/retest |
Adding packages installation and configuration to enable prometheus-exporter
857f3b5 to
742710b
Compare
|
/retest |
1 similar comment
|
/retest |
|
/test images |
|
/retest |
1 similar comment
|
/retest |
|
@elfosardo This doesn't appear to be a cherry-pick from https://github.com/metal3-io/ironic-image ? If I'm mistaken then we should include the upstream PR or commit reference in this commit message, or else include a justification for why this only makes sense in the forked image? |
|
nvm, I found it - this was added as part of metal3-io#101 In future it would be good to keep the commit naming etc aligned so it's easier to track from the upstream repo. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, dtantsur, elfosardo, hardys, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@elfosardo FYI this should also have updated I'll fix that in a followup |
Adding packages installation and configuration to enable prometheus-exporter
Also removing explicit install of python-chardet, as dependency it will be installed anyway with the correct python version