Skip to content

Conversation

@elfosardo
Copy link

Adding packages installation and configuration to enable prometheus-exporter

Also removing explicit install of python-chardet, as dependency it will be installed anyway with the correct python version

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2019
@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/retest

@iurygregory
Copy link

/approve

@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

retest

@elfosardo
Copy link
Author

/retest

Adding packages installation and configuration to enable
prometheus-exporter
@elfosardo elfosardo force-pushed the add-prometheus-exporter branch from 857f3b5 to 742710b Compare November 14, 2019 15:10
@elfosardo
Copy link
Author

/retest

1 similar comment
@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/test images

@elfosardo
Copy link
Author

/retest

1 similar comment
@elfosardo
Copy link
Author

/retest

@hardys
Copy link

hardys commented Nov 26, 2019

@elfosardo This doesn't appear to be a cherry-pick from https://github.com/metal3-io/ironic-image ?

If I'm mistaken then we should include the upstream PR or commit reference in this commit message, or else include a justification for why this only makes sense in the forked image?

@hardys
Copy link

hardys commented Nov 26, 2019

nvm, I found it - this was added as part of metal3-io#101

In future it would be good to keep the commit naming etc aligned so it's easier to track from the upstream repo.

@hardys
Copy link

hardys commented Nov 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, dtantsur, elfosardo, hardys, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bfournie,dtantsur,elfosardo,hardys]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 27f6b3a into openshift:master Nov 26, 2019
@hardys
Copy link

hardys commented Nov 26, 2019

@elfosardo FYI this should also have updated Dockerfile as otherwise we have conflicts doing cherry-picks from metal3-io/ironic-image

I'll fix that in a followup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants