Re-adding Train features#101
Merged
derekhiggins merged 1 commit intometal3-io:masterfrom Oct 16, 2019
Merged
Conversation
metal3-io-bot
added
the
size/M
elfosardo
force-pushed
the
train-features
branch
from
1f1d626 to
eb73cca
Compare
dtantsur
requested changes
Oct 9, 2019
elfosardo
force-pushed
the
train-features
branch
from
eb73cca to
3897029
Compare
dhellmann
suggested changes
Oct 9, 2019
dhellmann
approved these changes
Oct 9, 2019
metal3-io-bot
added
the
approved
elfosardo
force-pushed
the
train-features
branch
2 times, most recently
from
b856930 to
548c6e8
Compare
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1221/ |
elfosardo
force-pushed
the
train-features
branch
from
548c6e8 to
a152803
Compare
dtantsur
reviewed
Oct 14, 2019
dtantsur
reviewed
Oct 14, 2019
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1231/ |
This patch adds back the features that were removed because we were on Stain branch: - continuous introspection - ironic-prometheus-exporter - mdns support
elfosardo
force-pushed
the
train-features
branch
from
a152803 to
a98a0cc
Compare
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1236/ |
dtantsur
approved these changes
Oct 15, 2019
Member
dtantsur
left a comment
dtantsur
left a comment
There was a problem hiding this comment.
Looks good. Has anyone tried it?
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
CI has, the failure is unrelated and after the ironic parts, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds back the features that were removed because we
were on Stain branch:
Also fixes #102
Please merge this and metal3-io/ironic-inspector-image#38 at the same time!