Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Deprecate node-joiner scripts #9304

Merged
merged 1 commit into from
Jan 8, 2025
Merged

NO-ISSUE: Deprecate node-joiner scripts #9304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/user/agent/add-node/add-nodes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Adding a node via the node-joiner tool

## Deprecated

For OpenShift 4.17 and later, the node-joiner.sh and node-joiner-monitor.sh scripts cannot be used. The node-joiner scripts were created for OpenShift 4.16 as a development preview. They have been deprecated and replaced by the "oc adm node-image" command. See [Adding worker nodes to an on-premise cluster](https://docs.openshift.com/container-platform/4.17/nodes/nodes/nodes-nodes-adding-node-iso.html) for more details.

## Pre-requisites
1. The `oc` tool must be available in the execution environment (the "user host").
2. Ensure `oc` is properly configured to manage the cluster to be expanded, i.e. by either:
Expand Down
10 changes: 10 additions & 0 deletions docs/user/agent/add-node/node-joiner-monitor.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
#!/bin/bash
#
# Deprecated
#
# For OpenShift 4.17 and later, the node-joiner.sh and node-joiner-monitor.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could work also an echo I guess

# scripts cannot be used. The node-joiner scripts were created for
# OpenShift 4.16 as a development preview. They have been deprecated and
# replaced by the "oc adm node-image" command.
# See https://docs.openshift.com/container-platform/4.17/nodes/nodes/nodes-nodes-adding-node-iso.html
# for more details.
#

set -eu

Expand Down
10 changes: 10 additions & 0 deletions docs/user/agent/add-node/node-joiner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
#!/bin/bash
#
# Deprecated
#
# For OpenShift 4.17 and later, the node-joiner.sh and node-joiner-monitor.sh
# scripts cannot be used. The node-joiner scripts were created for
# OpenShift 4.16 as a development preview. They have been deprecated and
# replaced by the "oc adm node-image" command.
# See https://docs.openshift.com/container-platform/4.17/nodes/nodes/nodes-nodes-adding-node-iso.html
# for more details.
#

set -eu

Expand Down