Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Deprecate node-joiner scripts #9304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rwsu
Copy link
Contributor

@rwsu rwsu commented Dec 11, 2024

The scripts should only be used with OpenShift 4.16 and as a dev preview.

They have been replaced by the "oc adm node-image" command.

The scripts should only be used with OpenShift 4.16 and as a
dev preview.

They have been replaced by the "oc adm node-image" command.
@openshift-ci-robot
Copy link
Contributor

@rwsu: This pull request explicitly references no jira issue.

In response to this:

The scripts should only be used with OpenShift 4.16 and as a dev preview.

They have been replaced by the "oc adm node-image" command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2024
@rwsu
Copy link
Contributor Author

rwsu commented Dec 11, 2024

/cc @andfasano

@openshift-ci openshift-ci bot requested a review from andfasano December 11, 2024 06:25
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

#
# Deprecated
#
# For OpenShift 4.17 and later, the node-joiner.sh and node-joiner-monitor.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could work also an echo I guess

@andfasano
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants