Skip to content

WIP: add Makefile #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sallyom wants to merge 1 commit into from
Closed

WIP: add Makefile #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ jobs:
name: Go vet
- script: "docker run -v $PWD:$PWD -w $PWD quay.io/coreos/golang-testing golint -set_exit_status installer/..."
name: Go lint
- script: "chmod 0777 $PWD && docker run -v $PWD:$PWD:rw -w $PWD $BAZEL_IMG bazel test terraform_fmt --test_output=all"
name: Terraform tests
- script: "chmod 0777 $PWD && docker run -v $PWD:$PWD:rw -w $PWD $BAZEL_IMG bazel test installer:cli_units --test_output=all"
name: Installer unit tests
Copy link
Member

@wking wking Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave these in for now to make sure we're covered until Prow picks them up (the Terraform linter is in flight with openshift/release#1124).

- stage: Build
script: "chmod 0777 $PWD && docker run -v $PWD:$PWD:rw -w $PWD $BAZEL_IMG bazel build tarball"
name: Build tarball
20 changes: 20 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
all: test terraform_fmt

#terraform_files=$(shell find modules steps -type f -name "*.tf")
#terraform_files+=("config.tf")

#src_files=$(shell find installer -type f -name "*.go")

test:
Copy link
Member

@wking wking Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a more specific name like test-go or some such. But maybe test is a standard name for Go-only tests throughout OpenShift projects or something.

CGO_ENABLED=0 go test ./installer/pkg/...

terraform_fmt:
terraform fmt -list -check -write=false

#verify-gofmt:
# ./hack/gofmt-all.sh -v

#gofmt:
# ./hack/gofmt-all.sh

#verify: verify-gofmt test