WIP: add Makefile #91
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Can one of the admins verify this patch? |
openshift-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sallyom If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
This looks pretty good to me. I'm in favor of tackling this with a series of small PRs instead of one big Bazel -> Make PR, so I think we can go ahead and land this without waiting for it to grow larger :p.
| - script: "chmod 0777 $PWD && docker run -v $PWD:$PWD:rw -w $PWD $BAZEL_IMG bazel test terraform_fmt --test_output=all" | ||
| name: Terraform tests | ||
| - script: "chmod 0777 $PWD && docker run -v $PWD:$PWD:rw -w $PWD $BAZEL_IMG bazel test installer:cli_units --test_output=all" | ||
| name: Installer unit tests |
There was a problem hiding this comment.
I'd leave these in for now to make sure we're covered until Prow picks them up (the Terraform linter is in flight with openshift/release#1124).
|
|
||
| #src_files=$(shell find installer -type f -name "*.go") | ||
|
|
||
| test: |
There was a problem hiding this comment.
I'd prefer a more specific name like test-go or some such. But maybe test is a standard name for Go-only tests throughout OpenShift projects or something.
|
closing for now, in favor of small individual scripts for prow, will open a new PR w/ that in mind |
Bug 1913716: Use existing libraries instead of rolling our own
manual merge 20211213
4 participants
Before creating your PR, please make sure to add the appropriate GitHub label; i.e.
run-smoke-tests. For more details seetests/README.md.
(In case you don't have permissions to add labels, please ask a
Maintainer.)