asset/manifest: do not load network nor ingress from disk #877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither the network nor the ingress manifest assets are targeted assets. The installer does not write their files to disk. The installer should not load their files from disk.
In addition to the load issue, there is an issue with reading the config field when reading the assets from the state file. For the network asset, the config field is needed, but is not stored in the state file.
To resolve this, the config field has been made public. For the ingress asset, the config field is not needed: it has been removed.
Fixes https://jira.coreos.com/browse/CORS-938