Skip to content

Conversation

@staebler
Copy link
Contributor

Neither the network nor the ingress manifest assets are targeted assets. The installer does not write their files to disk. The installer should not load their files from disk.

In addition to the load issue, there is an issue with reading the config field when reading the assets from the state file. For the network asset, the config field is needed, but is not stored in the state file.
To resolve this, the config field has been made public. For the ingress asset, the config field is not needed: it has been removed.

Fixes https://jira.coreos.com/browse/CORS-938

Neither the network nor the ingress manifest assets are targeted assets.
The installer does not write their files to disk. The installer should
not load their files from disk.

In addition to the load issue, there is an issue with reading the
config field when reading the assets from the state file. For the network
asset, the config field is needed, but is not stored in the state file.
To resolve this, the config field has been made public. For the ingress
asset, the config field is not needed: it has been removed.

Fixes https://jira.coreos.com/browse/CORS-938
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2018
@staebler
Copy link
Contributor Author

@crawford I closed #871. This is the right fix for the issue of dirty manifests. The network and ingress manifests should not be loaded from disk at all.

@openshift-ci-robot
Copy link
Contributor

@staebler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 3316d5f link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@staebler
Copy link
Contributor Author

/close in favor of #890

@staebler staebler closed this Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants