asset/manifests: network and ingress equal from state file and on-disk

[staebler]

The on-disk and in-state-file versions of the Network and Ingress manifest assets are not evaluating as equal when read into the store. Consequently, they are being marked as dirty, even when the user has not made any changes to them. This propagates to the Operators and Openshift manifest assets, making them dirty as well.

For both assets, the underlying issue is that the config field is not stored in the state file but it is populated when loading from on-disk. The config field in manifests.Network has been made public, allowing it to be stored in the state file. The config field in manifests.Ingress has been removed, since it is not being used.

Fixes https://jira.coreos.com/browse/CORS-938

https://jira.coreos.com/browse/CORS-940 has been created to add tests to ensure that there are not more assets that have this same problem.

[crawford]

Nice. I hit this the other day and forgot to file an issue.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [crawford,staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@staebler: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	799525e	link	/test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[staebler]

This is the right solution to the wrong problem. The network and ingress assets should not even be loaded from disk. They are not written to disk by the installer as they are not targeted assets. Their Load functions should not load any files.

As an aside, this is an example of why I preferred to have the Load function in a separate TargetedAsset type instead of in the WritableAsset type. With it in the WritableAsset type, assets like network and ingress need to define an empty Load function. Maybe better documentation on the Load function in the interface would be sufficient.