terraform: remove tectonicClusterID tag on resources #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/hold
openshift-ci-robot
added
the
approved
Contributor
Author
|
All the usages of tectonicClusterID have been removed from other repos. We are ready to stop including the tag. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
@staebler do we need both commits or can we squash them? Let's leave them if there is value. I'm just curious. |
Contributor
Author
Contributor
|
The Tectonic tag was deprecated in v0.7.0, so I think this is safe to merge now. /lgtm |
The tectonicClusterID tag is replaced with openshiftClusterID. https://jira.coreos.com/browse/CORS-878
Contributor
Author
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tectonicClusterID tag is replaced with openshiftClusterID.
https://jira.coreos.com/browse/CORS-878
/hold
#817
openshift/machine-api-operator#147
openshift/cluster-ingress-operator#83
openshift/cluster-image-registry-operator#114
openshift/hive#126
openshift/master-dns-operator#8