Skip to content

replace tectonicClusterID tag with openshiftClusterID#114

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
staebler:replace_openshiftClusterID
Dec 11, 2018
Merged

replace tectonicClusterID tag with openshiftClusterID#114
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
staebler:replace_openshiftClusterID

Conversation

@staebler
Copy link
Contributor

@staebler staebler commented Dec 7, 2018

The tectonicClusterID tag is being replaced with openshiftClusterID in the installer. This change will use the new tag name.

Hold on openshift/installer#817.

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2018
@coreydaley
Copy link

/lgtm

@coreydaley
Copy link

/retest

@staebler
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2018
@staebler
Copy link
Contributor Author

/retest

@dmage
Copy link
Contributor

dmage commented Dec 11, 2018

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, dmage, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2018
@openshift-merge-robot openshift-merge-robot merged commit 1bfdcb2 into openshift:master Dec 11, 2018
@staebler staebler deleted the replace_openshiftClusterID branch December 11, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants