OCPBUGS-32981: baremetal: use ControlPlane.Replicas#8322
OCPBUGS-32981: baremetal: use ControlPlane.Replicas#8322openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
`*installConfig.ControlPlane.Replicas` is the canonical source of this information and we don't want to rely on the `IsMaster()` function. We also change how that number gets to the master-bmh-update.sh script. We template the number into the systemd service instead of the shell script. This gives us shellcheck.
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-reference
|
@honza: This pull request references Jira Issue OCPBUGS-32981, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@honza: This pull request references Jira Issue OCPBUGS-32981, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/retest-required |
|
/override ci/prow/e2e-aws-ovn |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@honza: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@honza: Jira Issue OCPBUGS-32981: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-32981 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5 participants
*installConfig.ControlPlane.Replicasis the canonical source of this information and we don't want to rely on theIsMaster()function.We also change how that number gets to the master-bmh-update.sh script. We template the number into the systemd service instead of the shell script. This gives us shellcheck.
This is a follow-up to #8316