OCPBUGS-32981: baremetal: template the number of master nodes#8316
Conversation
honza
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@honza: This pull request references Jira Issue OCPBUGS-32981, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@honza: This pull request references Jira Issue OCPBUGS-32981, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
@honza: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| sleep 20 | ||
| N=$(oc get bmh -n openshift-machine-api -l installer.openshift.io/role=control-plane --no-headers=true | wc -l) | ||
| done | ||
| N="{{ .PlatformData.BareMetal.MasterHostCount }}" |
There was a problem hiding this comment.
.sh.template files don't get shellcheck run on them. It's better to pass this as an environment variable in the systemd service so that we don't lose linting on shell scripts.
| templateData.Hosts = config.Hosts | ||
|
|
||
| for _, host := range config.Hosts { | ||
| if host.IsMaster() { |
There was a problem hiding this comment.
Isn't the Role optional for the user to provide? I'm not aware that we default it anywhere. See https://github.com/openshift/installer/blob/master/pkg/types/baremetal/validation/platform.go#L305-L318
*installConfig.ControlPlane.Replicas is the canonical source of this information.
|
@honza: Jira Issue OCPBUGS-32981: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-32981 has been moved to the MODIFIED state. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5 participants
No description provided.