Skip to content

CORS-3269: Azure ignite control plane machines#8126

Merged
openshift-merge-bot[bot] merged 7 commits intoopenshift:masterfrom
jhixson74:master_capi_ignite_control_plane
May 15, 2024
Merged

CORS-3269: Azure ignite control plane machines#8126
openshift-merge-bot[bot] merged 7 commits intoopenshift:masterfrom
jhixson74:master_capi_ignite_control_plane

Conversation

@jhixson74
Copy link
Member

@jhixson74 jhixson74 commented Mar 8, 2024 •
edited
Loading

Ignite the control plane machines, add outbound load balancer, and disable public IP on bootstrap machine.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 8, 2024 •
edited by openshift-ci bot
Loading

@jhixson74: This pull request references CORS-3269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Work in progress. Ignite the control plane machines.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 8, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 8, 2024 •
edited by openshift-ci bot
Loading

@jhixson74: This pull request references CORS-3269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Work in progress. Ignite the control plane machines.

Depends on #8018

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mtulio and patrickdillon March 8, 2024 05:17
patrickdillon
patrickdillon reviewed Mar 13, 2024
View reviewed changes
@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch from f4405e9 to aa0cfa0 Compare March 13, 2024 22:59
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2024 •
edited by openshift-ci bot
Loading

@jhixson74: This pull request references CORS-3269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Work in progress. Ignite the control plane machines.

Depends on #8018

Also has some commits cherry picked from #8115

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch from aa0cfa0 to 3de39d7 Compare March 14, 2024 01:06
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 14, 2024 •
edited by openshift-ci bot
Loading

@jhixson74: This pull request references CORS-3269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Work in progress. Ignite the control plane machines.

Depends on #8018, #8115, and #8045

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch 8 times, most recently from 024aec4 to c869536 Compare March 15, 2024 21:58
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 15, 2024 •
edited by openshift-ci bot
Loading

@jhixson74: This pull request references CORS-3269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Work in progress. Ignite the control plane machines.

Depends on #8018, #8115, and #8045

TODO:

  • Create CNAME once public ip is available
  • SAS for ignition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 15, 2024 •
edited by openshift-ci bot
Loading

@jhixson74: This pull request references CORS-3269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Work in progress. Ignite the control plane machines.

Depends on #8018, #8115, and #8045

TODO:

  • Create CNAME once public ip is available
  • SAS for ignition
  • NSG rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2024
@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch from c869536 to e8d1d05 Compare March 27, 2024 21:11
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2024
@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch from 0f0a980 to bb71396 Compare March 28, 2024 22:40
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2024
@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch from 59bae7b to 365a874 Compare March 29, 2024 00:38
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2024
@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch 2 times, most recently from e69d25a to 26ff1f8 Compare March 29, 2024 16:29
patrickdillon
patrickdillon reviewed Apr 30, 2024
View reviewed changes
@patrickdillon
Copy link
Contributor

patrickdillon commented May 2, 2024

@jhixson74 where did we land with the nsg rules? also did we need to add back the names for nsgs? we could tackle the nsgs in a separate pr.

right now ci is broke due to the machine provisioning time

@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch 2 times, most recently from 5392ae4 to 762d96e Compare May 3, 2024 01:55
patrickdillon
patrickdillon reviewed May 3, 2024
View reviewed changes
@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch from 762d96e to 5095b35 Compare May 3, 2024 20:58
@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch from 5095b35 to 1ef231c Compare May 3, 2024 21:36
@jhixson74 jhixson74 force-pushed the master_capi_ignite_control_plane branch from 1ef231c to 5733fb9 Compare May 3, 2024 23:03
@patrickdillon
Copy link
Contributor

patrickdillon commented May 4, 2024

/test altinfra-e2e-azure-capi-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2024 •
edited
Loading

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 c88b9096afe5f6748b415df6eba299ee084b3771 link true /test e2e-agent-compact-ipv4
ci/prow/okd-e2e-aws-ovn-upgrade 5733fb9 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-azurestack 5733fb9 link false /test e2e-azurestack
ci/prow/altinfra-e2e-azure-capi-ovn 5733fb9 link false /test altinfra-e2e-azure-capi-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

patrickdillon commented May 14, 2024

/approve
/lgtm

@patrickdillon
Copy link
Contributor

patrickdillon commented May 14, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels May 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@sadasu
Copy link
Contributor

sadasu commented May 14, 2024

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 14, 2024
@patrickdillon patrickdillon removed the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 15, 2024
@patrickdillon
Copy link
Contributor

patrickdillon commented May 15, 2024

/label backport-risk-assessed

/label acknowledge-critical-fixes-only

lol. that's the one I meant! 🤦

@openshift-merge-bot openshift-merge-bot bot merged commit 2b446e2 into openshift:master May 15, 2024
@jhixson74
Copy link
Member Author

jhixson74 commented May 15, 2024

yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@mtulio mtulio Awaiting requested review from mtulio

+2 more reviewers

@r4f4 r4f4 r4f4 left review comments

@rna-afk rna-afk rna-afk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jhixson74 @openshift-ci-robot @patrickdillon @openshift-bot @sadasu @r4f4 @rna-afk @openshift-merge-robot