CORS-3195: Azure CAPI Supplemental Load Balancers

[patrickdillon]

Adds support for creating an additional, external LB. As well as updating the capi-provisioned internal LB with config for the machine-config server.

/cc @rna-afk @jhixson74

[openshift-ci-robot]

@patrickdillon: This pull request references CORS-3195 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Adds support for creating an additional, external LB. As well as updating the capi-provisioned internal LB with config for the machine-config server.

/cc @rna-afk @jhixson74

Still need to update VM membership to join the backend pool.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@patrickdillon: This pull request references CORS-3195 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Adds support for creating an additional, external LB. As well as updating the capi-provisioned internal LB with config for the machine-config server.

/cc @rna-afk @jhixson74

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhixson74]

There are some gofmt and golint errors. Other than that, everything LGTM.

[jhixson74]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jhixson74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[patrickdillon]

Adding a ControlPlaneOutboundLB to allow outbound access to the bootstrap node:

+                               ControlPlaneOutboundLB: &capz.LoadBalancerSpec{
+                                       FrontendIPsCount: to.Ptr(int32(1)),
+                               },

and adding the bootstrap ignition commits, this enables control plane nodes to pull ignition

Note that adding this precludes you from adding a public ip to the VM (a vm with a public ip config cannot have an outbound rule).

[jhixson74]

/retest

[patrickdillon]

/retest

@jhixson74 I think the linting issues are fixed

[patrickdillon]

/retest

[openshift-ci]

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade	1eb9d4f	link	false	/test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-azurestack	1eb9d4f	link	false	/test e2e-azurestack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jhixson74]

/lgtm

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404031748.p0.gac3ac89.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

[nrb]

Created kubernetes-sigs/cluster-api-provider-azure#4755 to track implementing dual load balancer/endpoint logic upstream (a 4.17 concern), as well as creating OCPCLOUD-2588