AGENT-502: Enable agent tui #6898
Conversation
Extracts the agent-tui files from the assisted-installer-agent image. Fix the dracut script to set the correct selinux label.
openshift-ci-robot
added
the
jira/valid-reference
|
@andfasano: This pull request references AGENT-502 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Change the agent services sequence so that agent-interactive-console starts after set-hostname, and before node-zero and agent service. This will prevent installation to start until the interactive console completes.
andfasano
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
|
/retest-required |
|
openshift/agent-installer-utils#12 has merged |
pkg/asset/agent/image/agentimage.go
Outdated
There was a problem hiding this comment.
In a perfect world, *.so* files would end up being copied to /usr/local/lib64.
Maybe we should put the a path hierarchy under agent-files? (i.e. store stuff as /agent-files/bin/agent-tui and do rsync -a /agent-files/ /usr/local)
There was a problem hiding this comment.
In general I agree, in the sense that this is just a first rough mechanism to copy over stuff from the initramfs to the disk to have an initial integration, and it could be definitely improved as our requirements increase. We could follouwup in a subsequent pr
There was a problem hiding this comment.
This is worth at least a comment.
pkg/asset/agent/image/agentimage.go
Outdated
There was a problem hiding this comment.
If restorecon -F worked and avoided having to explicitly specify the type, that seems preferable.
There was a problem hiding this comment.
Not sure if I've missed something, but in my tests restorecon wasn't available
There was a problem hiding this comment.
It's in CoreOS, but maybe not in the initramfs 🙁
This version is used implicitly by the integration tests, and currently it contains the required updated images
andfasano
force-pushed
the
enable-agent-tui
branch
from
95c730b to
2cc87af
Compare
|
/lgtm |
|
/test ci/prow/unit |
|
@andfasano: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test unit |
| Description=Get interactive user configuration at boot | ||
| After=network-pre.target NetworkManager.service pre-network-manager-config.service selinux.service | ||
| Before=network.target network.service agent.service NetworkManager-wait-online.service | ||
| Before=network.target network.service agent.service node-zero.service NetworkManager-wait-online.service |
There was a problem hiding this comment.
Is network.service a real thing?
I thought for a minute that we should use Before=getty-pre.target (https://www.freedesktop.org/software/systemd/man/systemd.special.html#getty-pre.target), but that will block all consoles and we are only displaying on one console, so I think [email protected] is the right thing.
|
@andfasano: This pull request references AGENT-502 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@andfasano: This pull request references AGENT-502 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold Revision 2cc87af was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test e2e-agent-compact-ipv4 |
1 similar comment
|
/test e2e-agent-compact-ipv4 |
|
/test e2e-agent-sno-ipv6 |
|
The HA and SNO jobs are failing with sshd not coming up. They are both disconnected jobs, so the likely cause is https://issues.redhat.com/browse/OCPBUGS-8107. This should be resolved by https://issues.redhat.com/browse/AGENT-565 once it is revendored into the a-i-a repo. |
|
@andfasano: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-aws-ovn |
|
/test e2e-agent-sno-ipv6 |
5 participants
This patch finalizes the integration of the agent-tui binary within the agent ISO
This patch also bumps up the default release image to
registry.ci.openshift.org/origin/release:4.13, as it's required by the integration tests (as pointed out by @zane in the comment, there's also a ticket for it https://issues.redhat.com/browse/CORS-2235)