-
Notifications
You must be signed in to change notification settings - Fork 99
vendor agent-installer-utils to v0.0.0-20230228190135-5b30a39dadf6 #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor agent-installer-utils to v0.0.0-20230228190135-5b30a39dadf6 #506
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, gamli75, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 60.44% 60.39% -0.06%
==========================================
Files 70 70
Lines 3484 3484
==========================================
- Hits 2106 2104 -2
- Misses 1228 1229 +1
- Partials 150 151 +1
|
|
@osherdp would be possible to override the edge-e2e-metal-assisted? The failure does not seem related to the patch |
|
why not retest? |
Just to save some time and reduce the overall roundtrip (in case of some other fix), as the e2e-metal-assisted will take another couple of hours to complete approx. The assisted-installer-agent image will then be required (and thus implicitly this patch) by openshift/installer#6898, which in turn will take other 2/3 hrs to complete and verify that everything works ok (we're integrating the agent-tui) |
|
@andfasano: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Bumping up the agent-installer-utils version