Skip to content

Conversation

@andfasano
Copy link
Contributor

Bumping up the agent-installer-utils version

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 1, 2023
@openshift-ci openshift-ci bot requested review from eranco74 and omertuc March 1, 2023 08:43
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, gamli75, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #506 (54396b5) into master (2510ac8) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   60.44%   60.39%   -0.06%     
==========================================
  Files          70       70              
  Lines        3484     3484              
==========================================
- Hits         2106     2104       -2     
- Misses       1228     1229       +1     
- Partials      150      151       +1     
Impacted Files Coverage Δ
src/inventory/bmc.go 84.44% <0.00%> (-2.23%) ⬇️

@andfasano
Copy link
Contributor Author

@osherdp would be possible to override the edge-e2e-metal-assisted? The failure does not seem related to the patch

@osherdp
Copy link
Contributor

osherdp commented Mar 1, 2023

why not retest?
/retest

@andfasano
Copy link
Contributor Author

andfasano commented Mar 1, 2023

why not retest? /retest

Just to save some time and reduce the overall roundtrip (in case of some other fix), as the e2e-metal-assisted will take another couple of hours to complete approx. The assisted-installer-agent image will then be required (and thus implicitly this patch) by openshift/installer#6898, which in turn will take other 2/3 hrs to complete and verify that everything works ok (we're integrating the agent-tui)

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 07c4bdc into openshift:master Mar 1, 2023
paul-maidment pushed a commit to paul-maidment/assisted-installer-agent that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants