OCPBUGS-5782: CVE-2021-4235: Denial of Service in go-yaml #6769
Conversation
`github.com/go-yaml/yaml` is where the project lives but the package should be imported with `gopkg.in/yaml.v2` (https://gopkg.in/yaml.v2)
A flaw was found in go-yaml < 2.2.3. This issue occurs due to unbounded alias chasing, where a maliciously crafted YAML file can cause the system to consume significant system resources. If parsing user input, this may be used as a denial of service vector.
|
@r4f4: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira cherrypick OCPBUGS-5324 |
|
@r4f4: Jira Issue OCPBUGS-5324 has been cloned as Jira Issue OCPBUGS-5782. Retitling PR to link against new bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-bug
|
@r4f4: This pull request references Jira Issue OCPBUGS-5782, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@r4f4: No Bugzilla bug is referenced in the title of this pull request. Retaining the bugzilla/valid-bug label as it was manually added. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
barbacbd
left a comment
barbacbd
left a comment
There was a problem hiding this comment.
I know this it the fix for the CVE, but there are also newer versions of this software. It looks like if we do decide to move to newer versions though there are some considerations and possible differences in function calls based on the comments here: go-yaml/yaml@7649d45
However this looks good to me
/lgtm
|
/approve |
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@r4f4: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-5782 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Manual cherry-pick of #6741