OCPBUGS-5324: CVE-2021-4235 go-yaml: Denial of Service in go-yaml

[r4f4]

A flaw was found in go-yaml. This issue occurs due to unbounded alias chasing, where a maliciously crafted YAML file can cause the system to consume significant system resources. If parsing user input, this may be used as a denial of service vector.

[openshift-ci-robot]

@r4f4: This pull request references Jira Issue OCPBUGS-5324, which is invalid:

• expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

A flaw was found in go-yaml. This issue occurs due to unbounded alias chasing, where a maliciously crafted YAML file can cause the system to consume significant system resources. If parsing user input, this may be used as a denial of service vector.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[r4f4]

/jira refresh

[openshift-ci-robot]

@r4f4: This pull request references Jira Issue OCPBUGS-5324, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[barbacbd]

/lgtm but this also begs the question, should the installer have so many different yaml packages? The installer should probably try to drop to a common yaml package, suggesting the k8s package.

[barbacbd]

/lgtm

[sadasu]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ed8b918 and 2 for PR HEAD 8c38a49 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 14878f7 and 1 for PR HEAD 8c38a49 in total

[openshift-ci]

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade	8c38a49	link	false	/test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn	8c38a49	link	false	/test okd-e2e-aws-ovn
ci/prow/e2e-aws-ovn-disruptive	8c38a49	link	false	/test e2e-aws-ovn-disruptive
ci/prow/e2e-libvirt	8c38a49	link	false	/test e2e-libvirt
ci/prow/e2e-ovirt-sdn	8c38a49	link	false	/test e2e-ovirt-sdn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD face870 and 0 for PR HEAD 8c38a49 in total

[openshift-ci-robot]

@r4f4: All pull requests linked via external trackers have merged:

• openshift/installer#6741

Jira Issue OCPBUGS-5324 has been moved to the MODIFIED state.

Details

In response to this:

A flaw was found in go-yaml. This issue occurs due to unbounded alias chasing, where a maliciously crafted YAML file can cause the system to consume significant system resources. If parsing user input, this may be used as a denial of service vector.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[r4f4]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@r4f4: #6741 failed to apply on top of branch "release-4.12":

Applying: pkg/asset/manifests/vsphere: use correct import path for go-yaml
Using index info to reconstruct a base tree...
M	pkg/asset/manifests/vsphere/cloudproviderconfig.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/asset/manifests/vsphere/cloudproviderconfig.go
CONFLICT (content): Merge conflict in pkg/asset/manifests/vsphere/cloudproviderconfig.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 pkg/asset/manifests/vsphere: use correct import path for go-yaml
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.