AGENT-453: Create interactive console service for agent installer #6756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andfasano
reviewed
Jan 12, 2023
pkg/asset/agent/image/ignition.go
Outdated
Contributor
There was a problem hiding this comment.
Thanks for naming it agent-<...>, in the long term I think it'd be easier to rename all of our services with a known fixed prefix (for the sake of troubleshooting)
andfasano
reviewed
Jan 12, 2023
data/data/agent/systemd/units/agent-interactive-console.service
Outdated
Show resolved
Hide resolved
Users would like the ability to change their network configuration at the console if network connectivity problems are detected. To achieve this goal, this patch adds a new service called agent-interactive-console.service to block the login prompt and the agent services that pulls an image from the registry. The service will execute the agent TUI to allow users to update their network configuration. The TUI will check there is connectivity to the registry and to the rendezvous host. If the connectivity checks pass, the TUI exits, which also lead the interactive console service to exit, and this unblocks the login prompt and agent services waiting for pull from the registry, allowing the agent-based installer to proceed. The agent TUI will be added in a future patch. For now, the service executes a script that logs its presence, sleeps for 60 seconds, and exits. This should not block the automated flow. Added ConditionPathExists=/usr/local/bin/agent-tui, which means the service does not start nor is it active until the agent-tui binary is present at that path. Most of the service definition was lifted from celebdor's POC: openshift#6560 Signed-off-by: Richard Su <[email protected]>
The interactive console service will not start or be active until the path exists.
Contributor
|
/lgtm |
Create a .path to track existence of the agent-tui. If the agent-tui binary exists at the specified path, PathExists, then the unit agent-interactive-console.service will be enabled. If the agent-tui binary does not exist, then agent-interactive-console.service is not enabled.
rwsu
added a commit
to rwsu/installer
that referenced
this pull request
Jan 20, 2023
Update the interactive console service to have it check the current host can access the release image and rendezvous host. Display this connectivity information to the user before prompting to run the network configuration tui. If there is connectivity, then the prompt times out after 60s and the automation flow is allowed to continue. If there is a connectivity issue, then the network configuration tui will be executed to allow users to update. The tui, however, has not been integrated with the interactive console service, so in the meantime, there is a 60s sleep in place of executing the tui. This will be changed in a future patch. Depends on: openshift#6756 Signed-off-by: Richard Su <[email protected]>
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
/lgtm |
Contributor
|
@rwsu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users would like the ability to change their network configuration at the console if network connectivity problems are detected.
To achieve this goal, this patch adds a new service called agent-interactive-console.service to block the login prompt and the agent services that pulls an image from the registry.
The service will execute the agent TUI to allow users to update their network configuration. The TUI will check there is connectivity to the registry and to the rendezvous host. If the connectivity checks pass, the TUI exits, which also lead the interactive console service to exit, and this unblocks the login prompt and agent services waiting for pull from the registry, allowing the agent-based installer to proceed.
The agent TUI will be added in a future patch.
For now, the service executes a script that logs its presence, sleeps for 60 seconds, and exits. This should not block the automated flow.
Most of the service definition was lifted from @celebdor's POC: #6560
Signed-off-by: Richard Su [email protected]