WIP agent: present questionnare in interactive mode #6560
Conversation
TODO: * Disable the get-interactive-config.service in interactive mode * Write node0 value and rendezvousIP in the right places Signed-off-by: Antoni Segura Puimedon <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@celebdor: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| done | ||
|
|
||
| if $NODE_ZERO; then | ||
| print_addressing_info |
There was a problem hiding this comment.
The print_addressing_info is only displayed for Node0. The other nodes don't show their currently configured ip address. So it is unclear whether the nmtui should be used.
| ip -j a show | jq -r '. | map({name: .ifname, addresses: [.addr_info[] | .local]}) | .[] | select(.addresses | length > 0) | select( .name != "lo") | .name + ": " + (.addresses | join(" "))' | ||
| fi | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm assuming we need to add something here that checks if node0 is defined in the ISO. If it is defined and connectivity check passes, then the following loops should be skipped after a predetermined amount timeout (according to https://issues.redhat.com/browse/AGENT-455)
Users would like the ability to change their network configuration at the console if network connectivity problems are detected. To achieve this goal, this patch adds a new service called agent-interactive-console.service to block the login prompt and the agent services that pulls an image from the registry. The service will execute the agent TUI to allow users to update their network configuration. The TUI will check there is connectivity to the registry and to the rendezvous host. If the connectivity checks pass, the TUI exits, which also lead the interactive console service to exit, and this unblocks the login prompt and agent services waiting for pull from the registry, allowing the agent-based installer to proceed. The agent TUI will be added in a future patch. For now, the service executes a script that logs its presence, sleeps for 60 seconds, and exits. This should not block the automated flow. Added ConditionPathExists=/usr/local/bin/agent-tui, which means the service does not start nor is it active until the agent-tui binary is present at that path. Most of the service definition was lifted from celebdor's POC: openshift#6560 Signed-off-by: Richard Su <[email protected]>
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
TODO:
Signed-off-by: Antoni Segura Puimedon [email protected]