Skip to content

[release-4.12] OCPBUGS-4895: Set ip=dhcp,dhcp6 for master nodes on dualstack#6706

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.12from
openshift-cherrypick-robot:cherry-pick-6626-to-release-4.12
Jan 21, 2023
Merged

[release-4.12] OCPBUGS-4895: Set ip=dhcp,dhcp6 for master nodes on dualstack#6706
openshift-merge-robot merged 1 commit intoopenshift:release-4.12from
openshift-cherrypick-robot:cherry-pick-6626-to-release-4.12

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 15, 2022

This is an automated cherry-pick of #6626

/assign derekhiggins

@derekhiggins
Set ip=dhcp,dhcp6 for master nodes on dualstack
dfdfeef 
We were previously only seting this for workers but
its also needed on the master nodes to ensure both
networks are ready before ovnkube-node starts.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 15, 2022
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 15, 2022

@openshift-cherrypick-robot: Jira Issue OCPBUGS-3196 has been cloned as Jira Issue OCPBUGS-4895. Retitling PR to link against new bug.
/retitle [release-4.12] OCPBUGS-4895: Set ip=dhcp,dhcp6 for master nodes on dualstack

Details

In response to this:

This is an automated cherry-pick of #6626

/assign derekhiggins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-3196: Set ip=dhcp,dhcp6 for master nodes on dualstack [release-4.12] OCPBUGS-4895: Set ip=dhcp,dhcp6 for master nodes on dualstack Dec 15, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 15, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 15, 2022

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-4895, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-3196 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-3196 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @pamoedom

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #6626

/assign derekhiggins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-4895: Set ip=dhcp,dhcp6 for master nodes on dualstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins derekhiggins mentioned this pull request Dec 15, 2022
Closed
@elfosardo
Copy link
Contributor

elfosardo commented Dec 16, 2022

/retest

@elfosardo
Copy link
Contributor

elfosardo commented Dec 16, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@elfosardo
Copy link
Contributor

elfosardo commented Dec 23, 2022

/retest

@sadasu
Copy link
Contributor

sadasu commented Jan 4, 2023

/approve

@sadasu
Copy link
Contributor

sadasu commented Jan 4, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 4, 2023
@sadasu
Copy link
Contributor

sadasu commented Jan 4, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@jhixson74
Copy link
Member

jhixson74 commented Jan 18, 2023

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cybertron
Copy link
Member

cybertron commented Jan 19, 2023

@pamoedom Can you give this cherry-pick-approved? People are hitting it on 4.12 so we need to get the fix in ASAP. Thanks!

@pamoedom
Copy link
Contributor

pamoedom commented Jan 20, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2023

/retest-required

Remaining retests: 0 against base HEAD e33d9bd and 2 for PR HEAD dfdfeef in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc dfdfeef link false /test e2e-crc
ci/prow/e2e-aws-ovn-disruptive dfdfeef link false /test e2e-aws-ovn-disruptive
ci/prow/okd-scos-e2e-aws-ovn dfdfeef link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-libvirt dfdfeef link false /test e2e-libvirt
ci/prow/e2e-ibmcloud-ovn dfdfeef link false /test e2e-ibmcloud-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cybertron
Copy link
Member

cybertron commented Jan 20, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 303c9d4 into openshift:release-4.12 Jan 21, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2023

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4895 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #6626

/assign derekhiggins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rbo rbo mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pamoedom pamoedom Awaiting requested review from pamoedom

@iurygregory iurygregory Awaiting requested review from iurygregory

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@derekhiggins derekhiggins

@jhixson74 jhixson74

@elfosardo elfosardo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @elfosardo @sadasu @jhixson74 @cybertron @pamoedom @derekhiggins @openshift-merge-robot