Skip to content

OCPBUGS-3196: Set ip=dhcp,dhcp6 for master nodes on dualstack#6626

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
derekhiggins:set-dual-master
Dec 6, 2022
Merged

OCPBUGS-3196: Set ip=dhcp,dhcp6 for master nodes on dualstack#6626
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
derekhiggins:set-dual-master

Conversation

@derekhiggins
Copy link
Contributor

@derekhiggins derekhiggins commented Nov 24, 2022

We were previously only seting this for workers but its also needed on the master nodes to ensure both networks are ready before ovnkube-node starts.

@derekhiggins
Set ip=dhcp,dhcp6 for master nodes on dualstack
91caa20 
We were previously only seting this for workers but
its also needed on the master nodes to ensure both
networks are ready before ovnkube-node starts.
@openshift-ci-robot openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Nov 24, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 24, 2022

@derekhiggins: This pull request references Jira Issue OCPBUGS-3196, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We were previously only seting this for workers but its also needed on the master nodes to ensure both networks are ready before ovnkube-node starts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 24, 2022
@derekhiggins
Copy link
Contributor Author

derekhiggins commented Nov 24, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 24, 2022

@derekhiggins: This pull request references Jira Issue OCPBUGS-3196, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

dtantsur commented Nov 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@derekhiggins
Copy link
Contributor Author

derekhiggins commented Nov 25, 2022

/retest-required

1 similar comment
@derekhiggins
Copy link
Contributor Author

derekhiggins commented Nov 28, 2022

/retest-required

@elfosardo
Copy link
Contributor

elfosardo commented Nov 28, 2022

/cc @r4f4 @patrickdillon @sadasu

@cybertron
Copy link
Member

cybertron commented Nov 28, 2022

/lgtm

I confirmed locally that this is doing the right thing. Both my masters and workers now have ip=dhcp,dhcp6 like they should.

r4f4
r4f4 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@derekhiggins
Copy link
Contributor Author

derekhiggins commented Nov 29, 2022

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 29, 2022

/retest-required

Remaining retests: 0 against base HEAD 02f915f and 2 for PR HEAD 91caa20 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 29, 2022

/retest-required

Remaining retests: 0 against base HEAD f74ed03 and 1 for PR HEAD 91caa20 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 30, 2022

/retest-required

Remaining retests: 0 against base HEAD bca1b65 and 0 for PR HEAD 91caa20 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2022

/hold

Revision 91caa20 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022
@derekhiggins
Copy link
Contributor Author

derekhiggins commented Dec 1, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2022

/retest-required

Remaining retests: 0 against base HEAD a6bde70 and 2 for PR HEAD 91caa20 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2022

/retest-required

Remaining retests: 0 against base HEAD 0f7f0a6 and 1 for PR HEAD 91caa20 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2022

/retest-required

Remaining retests: 0 against base HEAD c45c58e and 0 for PR HEAD 91caa20 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2022

/hold

Revision 91caa20 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2022
@elfosardo
Copy link
Contributor

elfosardo commented Dec 2, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2022
@elfosardo
Copy link
Contributor

elfosardo commented Dec 2, 2022

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2022

/retest-required

Remaining retests: 0 against base HEAD c45c58e and 2 for PR HEAD 91caa20 in total

@derekhiggins
Copy link
Contributor Author

derekhiggins commented Dec 2, 2022

Images are failing to build in some of the jobs, looks like its because of a recent base image update
#6657

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 3, 2022

/retest-required

Remaining retests: 0 against base HEAD a2ed5c0 and 1 for PR HEAD 91caa20 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 3, 2022

/retest-required

Remaining retests: 0 against base HEAD cc689a2 and 0 for PR HEAD 91caa20 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 3, 2022

/hold

Revision 91caa20 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2022
@derekhiggins
Copy link
Contributor Author

derekhiggins commented Dec 5, 2022

/unhold
failing image builds should now be fixed

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
@r4f4
Copy link
Contributor

r4f4 commented Dec 5, 2022

/test e2e-gcp-ovn

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2022

/retest-required

Remaining retests: 0 against base HEAD 2c8fa13 and 2 for PR HEAD 91caa20 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2022

/retest-required

Remaining retests: 0 against base HEAD 1fb2774 and 1 for PR HEAD 91caa20 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022 •
edited
Loading

@derekhiggins: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 91caa20 link false /test e2e-openstack
ci/prow/e2e-agent-sno-ipv6 91caa20 link false /test e2e-agent-sno-ipv6
ci/prow/e2e-aws-ovn-disruptive 91caa20 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-agent-ha-dualstack 91caa20 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-libvirt 91caa20 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 6, 2022

/retest-required

Remaining retests: 0 against base HEAD b1e2e1b and 0 for PR HEAD 91caa20 in total

@openshift-merge-robot openshift-merge-robot merged commit 3bb6bd9 into openshift:master Dec 6, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 6, 2022

@derekhiggins: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3196 has been moved to the MODIFIED state.

Details

In response to this:

We were previously only seting this for workers but its also needed on the master nodes to ensure both networks are ready before ovnkube-node starts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Contributor Author

derekhiggins commented Dec 15, 2022

/cherry-pick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 15, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 15, 2022

@derekhiggins: new pull request created: #6706

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@elfosardo elfosardo Awaiting requested review from elfosardo

@rna-afk rna-afk Awaiting requested review from rna-afk

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sadasu sadasu Awaiting requested review from sadasu

1 more reviewer

@r4f4 r4f4 r4f4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dtantsur dtantsur

@cybertron cybertron

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@derekhiggins @openshift-ci-robot @dtantsur @elfosardo @cybertron @r4f4 @openshift-cherrypick-robot @openshift-merge-robot