Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #6265

/assign jianli-wei

@jianli-wei
Copy link
Contributor

@jianlinliu please help review, thanks!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 69070fe link false /test e2e-crc
ci/prow/e2e-aws-upi-proxy 69070fe link false /test e2e-aws-upi-proxy
ci/prow/e2e-ibmcloud 69070fe link false /test e2e-ibmcloud
ci/prow/e2e-openstack 69070fe link false /test e2e-openstack
ci/prow/e2e-libvirt 69070fe link false /test e2e-libvirt
ci/prow/e2e-vsphere 69070fe link false /test e2e-vsphere
ci/prow/e2e-vsphere-upi 69070fe link false /test e2e-vsphere-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jianlinliu
Copy link
Contributor

@jianli-wei I have no approve permission on the installer repo.

Pls check the message from openshif-ci bot - "Needs approved, backport-risk-assessed, bugzilla/valid-bug labels"

For "bugzilla/valid-bug labels", need file a bug to associate with the PR. here is an example.
For "approved, backport-risk-assessed", need dev team's review.

@sadasu
Copy link
Contributor

sadasu commented Sep 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@r4f4
Copy link
Contributor

r4f4 commented Sep 22, 2022

For "bugzilla/valid-bug labels", need file a bug to associate with the PR. here is an example. For "approved, backport-risk-assessed", need dev team's review.

Just a quick reminder that bug in this case means a Jira issue in the OCPBUGS project, since we can't create BZs anymore.

@jianli-wei
Copy link
Contributor

Pls check the message from openshif-ci bot - "Needs approved, backport-risk-assessed, bugzilla/valid-bug labels"
@jianlinliu I didn't found the message in this PR, could you clarify?

@r4f4
Copy link
Contributor

r4f4 commented Sep 29, 2022

Pls check the message from openshif-ci bot - "Needs approved, backport-risk-assessed, bugzilla/valid-bug labels"
@jianlinliu I didn't found the message in this PR, could you clarify?

@jianli-wei Look at the tests and you'll see one name tide. It shows what's missing for the PR to enter the merge pool.
tide

@jianli-wei
Copy link
Contributor

@jianli-wei Look at the tests and you'll see one name tide. It shows what's missing for the PR to enter the merge pool.

Understood, thanks!

@jianli-wei
Copy link
Contributor

/retitle [release-4.11] OCPBUGS-1876: download 'aliyun'

@openshift-ci openshift-ci bot changed the title [release-4.11] download 'aliyun' [release-4.11] OCPBUGS-1876: download 'aliyun' Sep 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.11] OCPBUGS-1876: download 'aliyun'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 30, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-1876, which is invalid:

  • expected the bug to target the "4.11.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-1876 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #6265

/assign jianli-wei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianli-wei
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jianli-wei: This pull request references Jira Issue OCPBUGS-1876, which is invalid:

  • expected the bug to target the "4.11.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-1876 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianli-wei
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 30, 2022
@openshift-ci-robot
Copy link
Contributor

@jianli-wei: This pull request references Jira Issue OCPBUGS-1876, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-1877 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-1877 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianli-wei September 30, 2022 03:47
@jianli-wei
Copy link
Contributor

/lgtm

@patrickdillon
Copy link
Contributor

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@jianlinliu
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 3d8f8dd into openshift:release-4.11 Oct 8, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1876 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #6265

/assign jianli-wei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants