Skip to content

Conversation

@jianli-wei
Copy link
Contributor

The alibabacloud client "aliyun" would be used when pre-configuring some resources (e.g. VPC, bastion host, etc.) before launching an OCP cluster with customization.

@openshift-ci openshift-ci bot requested review from jhixson74 and rna-afk August 25, 2022 03:49
@jianli-wei
Copy link
Contributor Author

/assign @jianlinliu @gpei please help review, thanks!

@jianlinliu
Copy link
Contributor

Suggest also update Dockerfile.upi.ci.rhel8 together.

@gpei
Copy link
Contributor

gpei commented Aug 25, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@jianli-wei
Copy link
Contributor Author

/assign @AnnaZivkovic

@jhixson74
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5c8ec74 and 2 for PR HEAD ec43235 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 679e56e and 1 for PR HEAD ec43235 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ba0e40c and 0 for PR HEAD ec43235 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision ec43235 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2022
@jianlinliu
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2022
@jianlinliu
Copy link
Contributor

/skip

1 similar comment
@jianlinliu
Copy link
Contributor

/skip

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ba0e40c and 2 for PR HEAD ec43235 in total

@jianlinliu
Copy link
Contributor

/skip

@jianlinliu
Copy link
Contributor

/override ci/prow/e2e-azure-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2022

@jianlinliu: jianlinliu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

Details

In response to this:

/override ci/prow/e2e-azure-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1c1a67a and 1 for PR HEAD ec43235 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5c45c5f and 0 for PR HEAD ec43235 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision ec43235 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2022
@jianlinliu
Copy link
Contributor

/skip

@jianlinliu
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cbb0b6c and 2 for PR HEAD ec43235 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a96d437 and 1 for PR HEAD ec43235 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daff033 and 0 for PR HEAD ec43235 in total

@jianlinliu
Copy link
Contributor

/skip

@openshift-ci-robot
Copy link
Contributor

/hold

Revision ec43235 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2022
@jianlinliu
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daff033 and 2 for PR HEAD ec43235 in total

@r4f4
Copy link
Contributor

r4f4 commented Sep 9, 2022

/override ci/prow/e2e-azure
/override ci/prow/e2e-azure-upi
/override ci/prow/e2e-aws-upi
/override ci/prow/e2e-gcp-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

@jianli-wei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud ec43235 link false /test e2e-ibmcloud
ci/prow/e2e-openstack ec43235 link false /test e2e-openstack
ci/prow/e2e-metal-ipi ec43235 link false /test e2e-metal-ipi
ci/prow/e2e-libvirt ec43235 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-aws-upi, ci/prow/e2e-azure, ci/prow/e2e-azure-upi, ci/prow/e2e-gcp-upi

Details

In response to this:

/override ci/prow/e2e-azure
/override ci/prow/e2e-azure-upi
/override ci/prow/e2e-aws-upi
/override ci/prow/e2e-gcp-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 28510e3 into openshift:master Sep 9, 2022
@jianli-wei
Copy link
Contributor Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@jianli-wei: new pull request created: #6376

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianli-wei
Copy link
Contributor Author

/cherry-pick release-4.11

@openshift-cherrypick-robot

@jianli-wei: new pull request created: #6377

Details

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants